249172 - DashMatchCompare should take a comparator parameter

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Using comparators more often in DashMatchCompare and AttrMatchesValue makes the
code simpler.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I've had this in my tree for ages.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 151994 [details] [diff] [review]
patch

I've had it in my tree for ages, but now that I look at it I did part of it
backwards.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Don't make language stuff case sensitive this time.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-07-06 16:29 -0700.

(There was one additional chunk at the beginning of the patch that I forgot to
untangle from another patch, but it was pretty simple.)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Codesize numbers from luna:

  libgklayout.so
  	Total:	       -360 (+664/-1024)
  	Code:	       -361 (+0/+0)
  	Data:	         +1 (+664/-1024)
  	       -360 (+664/-1024)	text (DATA)
  		       -360 (+664/-1024)	UNDEF:libgklayout.so:text
  			       +412	ValueIncludes(nsString const&, nsString const&,
nsStringComparator const&)
  			       +204	DashMatchCompare(nsAString const&, nsAString const&,
nsStringComparator const&)
  			        +47	SelectorMatches(RuleProcessorData&, nsCSSSelector*, int,
nsIAtom*, signed char)
  			         +1	.nosyms.text
  			       -177	AttrMatchesValue(nsAttrSelector const*, nsString const&)
  			       -234	DashMatchCompare(nsAString const&, nsAString const&, int)
  			       -613	ValueIncludes(nsString const&, nsString const&, int)