Closed
Bug 249305
Opened 21 years ago
Closed 21 years ago
nothing happens when clicking on "new folder" button from the "Move" dialog
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: t.lecavelier, Assigned: fpwoshg)
Details
(Whiteboard: fixed-aviary1.0)
Attachments
(1 file)
|
1.17 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1
When I go to the bookmark manager, then click on the "classify" button from the
tool bar, I obtain a dialog box. In that dialog, if I press the "new folder"
button, nothing happen at all.
Not yet implemented or bug?
Reproducible: Always
Steps to Reproduce:
1. Open bookmark manager
2. Click "classify" in the toolbar
3. Then select a branch in the tree and click "new folder" button
Actual Results:
Nothing at all : that's the problem.
Expected Results:
I expect that my favorite browser add a new node in the folder-tree on the left.
Same thing occur on Linux, with the same version and the same l10n (fr-FR WIP)
but I don't thing at all this could come from the l10n...
Bug confirmed with the en-US.
Bugzilla database search for, without result.
My apologies : the english term wasn't "Classify" but "Move".
Summary: nothing happen when clicking on "new folder" button from the "Classify" dialog → nothing happen when clicking on "new folder" button from the "Move" dialog
I can't find a dupe either, confirming on:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040701
Firefox/0.9.0+
Looks like this:
http://lxr.mozilla.org/aviarybranch/source/browser/components/bookmarks/content/addBookmark.js#291
needs to be updated to match this:
http://lxr.mozilla.org/aviarybranch/source/xpfe/components/bookmarks/resources/addBookmark.js#290
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•21 years ago
|
||
Pike, care to attach a patch based on that? :)
Here you go (can you believe I managed that much coding in just 42 hours)!
Assignee: p_ch → pike
Status: NEW → ASSIGNED
Attachment #152288 -
Flags: review?(mconnor)
Comment 6•21 years ago
|
||
Comment on attachment 152288 [details] [diff] [review]
Update createNewFolder
42 hours is good enough for me! :)
will handle this in my checkin blitz... which is going to be a big one if/when
I escape my work project... grumble grumble
Attachment #152288 -
Flags: review?(mconnor) → review+
Comment 7•21 years ago
|
||
fixed, branch and trunk
thanks pike!
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Summary: nothing happen when clicking on "new folder" button from the "Move" dialog → nothing happens when clicking on "new folder" button from the "Move" dialog
Updated•21 years ago
|
Whiteboard: fixed-aviary1.0
Comment 8•19 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•