24933 - [BETA1] Non-ASCII Rel Links show up in garbage on cached page

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[blee]

To see this,
1) Launch Seamonkey and click on the URL above.
2) Check Sidebar| Related Links (JA links should be displayed fine here).
3) Click Back button to return to Netcenter home page.
4) Click Forward button to get back to Mainichi newspaper. 

==> JA links show up in garbage.

blds: Win32 01-21-09-M14, Mac 01-24-08-M14, Linux 01-19-08-M14

Comment 1

[blee]

*** Bug 24557 has been marked as a duplicate of this bug. ***

Comment 2

[[e-mail] (away - not reading bugmail)]

here is the fix
E:\Mozilla\xpfe\components\related\src>cat k.txt
Index: nsRelatedLinksHandler.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/related/src/nsRelatedLinksHandler.cpp
,v
retrieving revision 1.32
diff -c -r1.32 nsRelatedLinksHandler.cpp
*** nsRelatedLinksHandler.cpp   2000/01/31 23:45:08     1.32
--- nsRelatedLinksHandler.cpp   2000/02/02 22:44:30
***************
*** 84,90 ****
  {
  private:
        nsCOMPtr<nsIRDFDataSource>      mDataSource;
-       nsCOMPtr<nsIUnicodeDecoder>     mUnicodeDecoder;
        nsVoidArray                     mParentArray;

        // pseudo-constants
--- 84,89 ----
***************
*** 98,103 ****
--- 97,103 ----
        static nsIRDFResource           *kNC_BookmarkSeparator;
        static nsIRDFResource           *kNC_RelatedLinksTopic;
        static nsIRDFResource           *kRDF_type;
+       static nsCOMPtr<nsIUnicodeDecoder>      mUnicodeDecoder;

        nsAutoString                    mBuffer;

***************
*** 130,138 ****
  nsIRDFResource                *RelatedLinksStreamListener::kNC_BookmarkSeparat
or;
  nsIRDFResource                *RelatedLinksStreamListener::kNC_RelatedLinksTop
ic;
  nsIRDFResource                *RelatedLinksStreamListener::kRDF_type;


-
  ////////////////////////////////////////////////////////////////////////


--- 130,138 ----
  nsIRDFResource                *RelatedLinksStreamListener::kNC_BookmarkSeparat
or;
  nsIRDFResource                *RelatedLinksStreamListener::kNC_RelatedLinksTop
ic;
  nsIRDFResource                *RelatedLinksStreamListener::kRDF_type;
+ nsCOMPtr<nsIUnicodeDecoder>   RelatedLinksStreamListener::mUnicodeDecoder;


  ////////////////////////////////////////////////////////////////////////


***************
*** 180,185 ****
--- 180,186 ----
                 NS_IF_RELEASE(kNC_RelatedLinksTopic);
                 NS_IF_RELEASE(kRDF_type);
                 NS_IF_RELEASE(kNC_RelatedLinksRoot);
+                mUnicodeDecoder = nsnull;

                 nsServiceManager::ReleaseService(kRDFServiceCID, gRDFService);
         }
rjc, please review it

Comment 3

[Robert John Churchill]

Looks good.

Comment 4

[[e-mail] (away - not reading bugmail)]

OK, I'm closing this - awaiting functional verification

Comment 5

[Frank Tang]

Mark this as M14 so QA will start the verify process.

Comment 6

[blee]

Verified fixed in Win32 02-17-09-M14, Mac 02-17-08-M14, Linux 02-17-08-M14 blds.