249669 - Move dialog in Bookmarks Manager has words "Create in:"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Daniel McKenzie]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1

The Move button dialog box that appears has the words "Create in:" to the left
of the folder tree. I think this should be "Move to:" as the bookmark is
basically already created and the word Create might make people think that it
makes a copy of the bookmark or something. Moving is what the user is expecting
to take, not Creating.

Reproducible: Always
Steps to Reproduce:
1. In Firefox, goto Bookmarks > Manage Bookmarks.
2. Click on a bookmark or folder to enabled the Move button.
3. Click Move on the toolbar.

Actual Results:  
The dialog has the words "Create in".

Expected Results:  
It would be a good idea for the words "Create in" to be changed to "Move to" for
the reasons above.

Comment 1

[Alex Eng]

The "Create in" text label is still present in the move bookmark dialog box as
of Firefox 0.8.0+
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040705 Firefox/0.8.0+

Funny that I've never noticed this before... no duplicates found.
Confirming.

Comment 2

[Adam Becevello]

I just did some digging through the source of the Move button in the bookmarks
manager and I found out that all it does it open the standard add bookmark
dialog.  So changing the label would cause the add bookmark dialog to have the
changed label as well.

For those that are interested, the move bookmark command is here:
http://lxr.mozilla.org/aviarybranch/source/browser/components/bookmarks/content/bookmarks.js#500

Comment 3

[Mike Connor [:mconnor]]

note that the current add bookmark dialog is addBookmark2.xul, so that's not
necessarily true.

Comment 4

[Asa Dotzler [:asa]]

Would be another nice "polish" cleanup for Firefox 1.0.

Comment 5

[Blake Ross]

-> vlad

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: Simple three line fix

Changes the label in addBookmark.xul. As mconnnor said, the add bookmark is
using addBookmark2, so this only affects the moving dialog box. I suppose this
should be cleaned up a little bit, and also the DTD files have some unused
entries. I can submit a patch for that if it's desired, but I figured it could
be done easier by someone with direct cvs access.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 154621 [details] [diff] [review]
Simple three line fix

I'm supposing that these files could be cleaned up by whoever checks this in,
if not, then I can submit a patch.

Comment 8

[Mike Connor [:mconnor]]

twiddle flags a bit as this is a l10n impact bug.

Vlad, please review this and drive it in :)

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 154621 [details] [diff] [review]
Simple three line fix

r=vladimir

I'd like to see addBookmark.xul also get renamed to moveBookmark.xul, but
that'll take CVS surgery and there's probably no reason to do that now.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154621 [details] [diff] [review]
Simple three line fix

a=me

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in on branch/trunk. thanks for the patch!

Comment 12

[Tracy Walker [:tracy]]

Verified with Windows 2004-08-12-08-0.9+ 

Comment 13

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change