250119 - xmlextras: ParseFromString/ParseFromStream should use AUTF8Strings

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

the parse bits should use AUTF8String to avoid high-bit string lossage from js;
also adds ParseFromUTF8String.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: xmlextras-stringparse-1.patch

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

01:59 <jst> r=jst
01:59 <jst> you want that in a bug?
02:00 <vlad> sure, 250119
02:00 <jst> hmm, no patch yet... feel free to add r=jst yourself once you've got
a patch

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 152483 [details] [diff] [review]
xmlextras-stringparse-1.patch

Marking my and jst's approval.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in on trunk and aviary.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: stringparse-2.patch

Attaching patch that went in for posterity's sake; combo of this patch and
first iteration of the patch in bug 244078.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

landed/synced on 1.7