250247 - Add account settings for RSS account

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Scott MacGregor]

Options so far include:

biff interval

download new feeds on startup

Comment 1

[Scott MacGregor]

We do a very good job of letting an extension dynamically add panels to an
incoming server's account manager. This is how PGP Mime and S/MIME add Security
panels under imap and POP accounts. 

See:
http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMsgAccountManagerDS.cpp#387
http://lxr.mozilla.org/mozilla/source/mailnews/extensions/smime/src/smime-service.js#58

Unfortunately, we don't allow you to override/extend the primary page for the
incoming server (i.e. am-main.xul). If you look at line 387 in
nsMsgAccountManagerDS.cpp, you'll see we check to see if the data source node is
a folder (which means it's the root folder for the account). If it is, we'll
return am-main.xul (or am-serverwithnoidentities.xul) as the page for this node
in the account manager data source. Otherwise, we fall back and use the account
manager extension APIs to get the chrome url for the panel.

I wonder if there's a way we can make this code also allow the panel to be
overwritten in the case where it is the server and not a sub category. 

Comment 2

[Scott MacGregor]

Attachment: work in progress

This gets the new account panel for RSS working. Right now it just has two
check boxes: one for the biff interval and another for checking for new
articles at startup.

verbage and UI subject to change.

David, I'm running into one problem right now with my attempts to check for new
feeds at startup. I added a PerformBiff method to the incoming server which
gets called at startup (assuming you checked that option) which iterates over
each folder in the RSS hierarchy and tells it to get new mail. My problem is
that the url we extract from the database for each RSS folder is always empty:

folderInfo->GetCharPtrProperty("feedUrl", getter_Copies(url));

I never get a feed URL.

Comment 3

[David :Bienvenu]

the feed url is supposed to get set by the subscribe UI (some changes I made to
the subscribe UI, not in Myk's original code) - I'll try to figure out why
that's not working.

Comment 4

[David :Bienvenu]

Attachment: fix for problem Scott described.

this should fix the problem you described - the url will now get set correctly.
However, I, in turn, ran into a problem - the subscribe UI now asks you for a
title for the feed, instead of letting the title get constructed automatically.
This causes two folders to get created; one with the title you give the feed,
and the other with the title constructed automatically. Do we really need to
ask for the title? I can try to fix the dual folder problem...

Comment 5

[David :Bienvenu]

Attachment: fix feed title

use folder name for title, instead of "Slashdot" :-)

Comment 6

[David :Bienvenu]

Attachment: fix feed title v2 - forgot idl file change

Comment 7

[Scott MacGregor]

Attachment: first cut

this patch includes David's patch in attachment 152707 [details] [diff] [review]. 

I also added a property on nsIMsgIncomingServer that allows the incoming server
to specify the main account manager xul file that is loaded for that server
instead of hard coding am-main.xul in the account manager data source. 

I also used the account manager extension APIs to allow our RSS extension to
dynamically add panels to the account manager.

This patch also hooks up ::PerformBiff, check for new feeds at startup. And
biff for new articles every n minutes where n is configurable via the account
manager panel.

I expect the account manager panel UI to change quite a bit over the coming
weeks as we add stuff to it.

Comment 8

[David :Bienvenu]

Comment on attachment 152790 [details] [diff] [review]
first cut

this looks fine as a first cut.

Comment 9

[Scott MacGregor]

this is fixed on the branch and the trunk