250396 - Clean up Web Search commandkeys

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P1)

Description

[Christoph Jerolimov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608 Firefox/0.8

User-Agent: Mozilla Firefox 0.9.1

(Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608 Firefox/0.8)


In my menu i see this:
 > File
 > Edit
   > Undo        Ctrl-Z
   > Redo        Ctrl-Y
   [...]
 [...]
 > Tools
   > Downloads   Ctrl-Y
 [...]


In earlier versions then Shortcut for open
the download manager was (when i remember correct) Ctrl-E, and i think it was
the "better" way.


So i can use Ctrl-Y to open the download manager "in normal sitations", but when
im in an textarea-Field (like now) and remove some text, make it undo and will
it make redo again, Ctrl-Y do it... The same key for two funktions!?


Sorry for my bad englsh, bug i hope you understand me. ;)



Greets Christoph Jerolimov

Reproducible: Always
Steps to Reproduce:
1. See menu
2. Press Ctrl-Y in normal mode -> open download manager
3. Edit a text in a field, make it undo, and redo (with Ctrl-Y again)

Actual Results:  
The "correct" funktion, but so have one key to funktions, which are colled "random".

Comment 1

[shadytrees]

Yes, this is the intended behavior so that Ctrl-Y changes as focus changes (from
content to input areas). -> Invalid/Wontfix

Comment 2

[u49640]

assigning 2 completely unrelated function the same shortcut can never be
intended.  (that completly breaks the idea of Menu shortcuts)
or if it is intended its just bad design

setting blocking-aviary1.0PR ?

btw: in the german Lang Pack the dl manager is changed to ctrl - e

Comment 3

[sairuh (rarely reading bugmail)]

confirming, sending over to keyboard shortcuts.

Comment 4

[Blake Ross]

-> ben

This really does need to be fixed.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 6

[Unknown W. Brackets]

Forgive me, but I remember this being changed intentionally.  I'm not sure where
the bug was, but I believe it has something to do with gnome-specific key
mappings. (something like it could not be A, B, C, D, or E.)

-[Unknown]

Comment 7

[:deanis74]

Ben, you can't use Ctrl+Shift+E.  It interferes with Unicode input on some
platforms.  See bug 186789.

Comment 8

[Steffen Wilberg]

Blake, your checkin comment was "Change download manager keybinding to Ctrl+J
(remove Page Info accelerator on Windows)". You did the latter, but not the
former. Ctrl+J is still Web Search on Linux and Ctrl+E is Downloads.

Please also note that the same key is to be used to close the download manager,
so it has to be changed here as well:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/content/downloads.xul&rev=1.8.14.3&mark=79#79
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd&rev=1.1.2.3&mark=31#31

I've traced the history of Web Search in bug 250286. Changed 5 times so far. The
current state is "Ctrl-E and Ctrl-K on all platforms except Linux, where it's
Ctrl-J." (Ctrl+K is "kill end of line on Linux.) I've suggested in that bug to
use Ctrl+E on all platforms, but then Ben made the last change, noting "also
support Ctrl+K for searches, since its use is entrenched. E is IE compat".

Since I'd really like to clean up this platform-specific keybinding mess, I'd
suggest this:
Search:    Ctrl+E (IE compat). Just dump Ctrl+K altogether.
Downloads: Ctrl+J.
Page Info: Either Ctrl+I on all platforms except Windows, where Ctrl+I is
Bookmarks, or none at all, because it's not used that often.

Comment 9

[Steffen Wilberg]

By the way, Ctrl+E still focusses the Search bar, because of this:
<!ENTITY searchFocus.commandkey2      "e">
See comment 8 at the bottom for my suggestion to clean up this mess.

Comment 10

[Steffen Wilberg]

Attachment: clean up this mess

This is what I suggested in comment 8:
Ctrl+E is Web Search.
Ctrl+J is Downloads.
Ctrl+I is Page Info on all platforms except Windows, where it's View Bookmarks
Sidebar (IE compat).

Comment 11

[Steffen Wilberg]

Comment on attachment 156770 [details] [diff] [review]
clean up this mess

Blake, can you r/a+ this, please? 1.0PR blocker.

Comment 12

[Cedric Roijakkers]

*** Bug 256587 has been marked as a duplicate of this bug. ***

Comment 13

[Christian Reis]

Remember that on Linux, Ctrl-A is beginning-of-line and Ctrl-E is end-of-line.
Don't collide with those. Platform-specific does seem to be the only way to go,
however.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 156770 [details] [diff] [review]
clean up this mess

No, let's NOT remove Ctrl+K for search. It's conveniently located near Ctrl+L
(location bar), and we've been using it for more than a year. We want to
encourage people to use this keybinding, not Ctrl+E, since Ctrl+E is too close
to Ctrl+W which is potentially dangerous. We can support Ctrl+E for IE compat,
but that does not mean we need to promote it. 

Ctrl+J for Downloads is fine since Page Info really isn't that common an
operation. 

I've reverted changes that mess with Ctrl+K before, so maybe you should add a
comment to the DTD/XUL file saying "DO NOT CHANGE THESE KEYBINDINGS OR BEN WILL
KILL YOU" ;-)

Comment 15

[Steffen Wilberg]

Removing "Downloads" from the summary since Blake fixed that already to Ctrl+J.

Comment 16

[Steffen Wilberg]

The Tools menu now looks like this on Linux:
  Web Search Ctrl+J
  Downloads  Ctrl+J

The former takes precedence.

-> Keyboard Navigation.

Comment 17

[Steffen Wilberg]

Attachment: Ctrl-E for everyone, Ctrl-K for everyone except Linux

1. Changes the commandkeys to Ctrl-E for everyone plus Ctrl-K for everyone
except Linux.
2. Lowercases downloads.commandkey, since commandkeys are always lowercased.
3. Changes the Download Manager's cmd.close2.commandKey to "j" to match the
downloads.commandkey.
4. Updates the Help doc on the Web Search shortcut.

Comment 18

[Steffen Wilberg]

Comment on attachment 156969 [details] [diff] [review]
Ctrl-E for everyone, Ctrl-K for everyone except Linux

Ben, please see comment 16 and comment 17.

Comment 19

[Robert Parenton]

Is a commandkey going to be reintroduced for Page Info on Windows, as it seems
to have been completely eliminated in all this cleanup?

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

So what does linux get? Linux was using Ctrl+J. I propose that it's more
important Linux retains a keybinding for search than for Downloads. Let's make
it so that:

Ctrl+K works on Windows/Mac for search field
Ctrl+J continues to work on Linux for search field
Ctrl+J works on Windows/Mac for downloads

... although I'm a little hazy on what the problem with Ctrl+K was on Linux...
what was it used for, again?

Comment 21

[Fareed Rizkalla]

i think keybinding should be rethought for the 1.0 mark

Comment 22

[Asher]

On 20040825, CTRL-J works to bring up the downloads manager, but you still need
t hit CTRL-Y to close it with the keyboard.

Comment 23

[Jeff Walden (gone starting June 8)]

(In reply to comment #22)
> On 20040825, CTRL-J works to bring up the downloads manager, but you still need
> t hit CTRL-Y to close it with the keyboard.

The latest attached patch fixes this.

Comment 24

[Jeff Walden [:Waldo]]

*** Bug 256939 has been marked as a duplicate of this bug. ***

Comment 25

[Steffen Wilberg]

Attachment: kill the Downloads commandkey in Linux

As suggested in comment 20:
I've left the keys for Web Search in place, that is
Ctrl+J on Unix
Ctrl+E (for IE compat) and Ctrl+K (because we like it) on other platforms.

Ctrl+J is Downloads on platforms except Unix. No key on Unix for Downloads.

> ... although I'm a little hazy on what the problem with Ctrl+K was on
Linux...
> what was it used for, again?
I've added a lenghty comment to browser.dtd:
<!-- Be careful when changing these keys. Ctrl+K is 'kill end of line',
     Ctrl+E is 'jump to end of line' in Linux when textareas are focussed.
     But we use Ctrl+E on other platforms to be compatible with IE.
     And ask Ben before changing Ctrl+K :)				    -->

Comment 26

[Steffen Wilberg]

Comment on attachment 157066 [details] [diff] [review]
kill the Downloads commandkey in Linux

This works as intended on Linux. I hope it does on other platforms as well.

We should really introduce a XP_UNIX_BUT_NOT_MACOSX.

Comment 27

[u62829]

What's going to happen here?  I feel it's a big regression not to have a
shortcut for downloads under Linux.  And the menu still shows Ctrl+J for
downloads _and_ Websearch.  I never use the Websearch, I search from location
bar, so IMHO the priority "Websearch over Downloads" shouldn't be an argument. 
I think we need keys for both.

Comment 28

[Asaf Romano (gone)]

What abou (*Linux Only*) Accel+Shift+J for downloads?

Comment 29

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 157066 [details] [diff] [review]
kill the Downloads commandkey in Linux

OK, let's try this. r+a=[e-mail].

Comment 30

[Robert Parenton]

>-<!ENTITY downloads.commandkey         "J">
>+<!ENTITY downloads.commandkey         "j">

Shouldn't that J remain capitalized to stay consistent with the rest of the code
around it?

Comment 31

[Mike Connor [:mconnor]]

commandkeys are generally lowercased in that file, so no

Comment 32

[Mike Connor [:mconnor]]

checked in on branch

emacs keybindings are really turning into a major pain.

Comment 33

[eric lindvall]

If trying to not interfere with "normal" UNIX key-bindings is something that
we're trying to be aware of, what of the CTRL-U-as-clear-line and
CTRL-U-as-view-source conflicts? I've always been annoyed when the "view source"
windows pops up when I wanted to clear the URL bar.

Comment 34

[John Lemon]

> Ctrl+I is Page Info on all platforms except Windows,
> where it's View Bookmarks Sidebar (IE compat).

In general, it's far more important to maintain compatibility across platforms
than to maintain compatibility with a completely different browser. It is
terribly confusing and frustrating to move between Linux, Windows, and Mac OS X
throughout the day and have to remember which keys to type in which cases in the
same application.

Specifically regarding Ctrl+I, we don't need two shortcuts on Windows for
bringing up the bookmarks sidebar, Ctrl+I is really the logical choice for page
Information, and Ctrl+I is already in use on platforms other than Windows for
page info.

Comment 35

[Steffen Wilberg]

This has been fixed on trunk as well by the branch landing.