Closed
Bug 250474
Opened 20 years ago
Closed 20 years ago
Change nsIWebPageDescriptor.LoadPage to nsIWebPageDescriptor.loadPage
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(2 files)
|
4.34 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
|
3.27 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
This interface is not yet frozen so it should be changed before it's frozen.
Attachment #152643 -
Flags: superreview?(bzbarsky)
Attachment #152643 -
Flags: review?(bzbarsky)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 152643 [details] [diff] [review] change LoadPage to loadPage r+sr=jst
Attachment #152643 -
Flags: superreview?(bzbarsky)
Attachment #152643 -
Flags: superreview+
Attachment #152643 -
Flags: review?(bzbarsky)
Attachment #152643 -
Flags: review+
mozilla/xpfe/browser/resources/content/viewsource.js 1.44 mozilla/docshell/base/nsIWebPageDescriptor.idl 1.2 mozilla/toolkit/components/viewsource/content/viewSource.js 1.7
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 4•20 years ago
|
||
viewSource.js in toolkit wasn't updated. This is breaking the Syntax Highlighting menu option and probably causes some other errors. Patch coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 5•20 years ago
|
||
Attachment #174627 -
Flags: superreview?(jst)
Attachment #174627 -
Flags: review?(jst)
|
|
||
Updated•20 years ago
|
Flags: blocking-aviary1.1?
|
|
||
Comment 6•20 years ago
|
||
Comment on attachment 174627 [details] [diff] [review] LoadPage -> loadPage r+sr=jst
Attachment #174627 -
Flags: superreview?(jst)
Attachment #174627 -
Flags: superreview+
Attachment #174627 -
Flags: review?(jst)
Attachment #174627 -
Flags: review+
|
|
||
Comment 7•20 years ago
|
||
Johnny, can you check this in? Thanks.
|
||
Comment 8•20 years ago
|
||
> viewSource.js in toolkit wasn't updated.
Actually, it was. Then some people took it upon themselves to back out those
changes when they landed the Aviary branch.
Re-resolving; this bug should never have been reopened.Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
|
|
||
Updated•20 years ago
|
Keywords: aviary-landing
|
|
||
Comment 9•20 years ago
|
||
Relanded the toolkit changes. Want to start a pool on when we'll find the last regressions from the aviary landing? ;)
Keywords: aviary-landing
|
||
Updated•20 years ago
|
Flags: blocking-aviary1.1?
|
||
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•