Closed Bug 250474 Opened 22 years ago Closed 21 years ago

Change nsIWebPageDescriptor.LoadPage to nsIWebPageDescriptor.loadPage

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(2 files)

This interface is not yet frozen so it should be changed before it's frozen.
Attachment #152643 - Flags: superreview?(bzbarsky)
Attachment #152643 - Flags: review?(bzbarsky)
Comment on attachment 152643 [details] [diff] [review] change LoadPage to loadPage r+sr=jst
Attachment #152643 - Flags: superreview?(bzbarsky)
Attachment #152643 - Flags: superreview+
Attachment #152643 - Flags: review?(bzbarsky)
Attachment #152643 - Flags: review+
Assignee: adamlock → timeless
mozilla/xpfe/browser/resources/content/viewsource.js 1.44 mozilla/docshell/base/nsIWebPageDescriptor.idl 1.2 mozilla/toolkit/components/viewsource/content/viewSource.js 1.7
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
viewSource.js in toolkit wasn't updated. This is breaking the Syntax Highlighting menu option and probably causes some other errors. Patch coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #174627 - Flags: superreview?(jst)
Attachment #174627 - Flags: review?(jst)
Flags: blocking-aviary1.1?
Comment on attachment 174627 [details] [diff] [review] LoadPage -> loadPage r+sr=jst
Attachment #174627 - Flags: superreview?(jst)
Attachment #174627 - Flags: superreview+
Attachment #174627 - Flags: review?(jst)
Attachment #174627 - Flags: review+
Johnny, can you check this in? Thanks.
> viewSource.js in toolkit wasn't updated. Actually, it was. Then some people took it upon themselves to back out those changes when they landed the Aviary branch. Re-resolving; this bug should never have been reopened.
Status: REOPENED → RESOLVED
Closed: 22 years ago21 years ago
Resolution: --- → FIXED
Relanded the toolkit changes. Want to start a pool on when we'll find the last regressions from the aviary landing? ;)
Keywords: aviary-landing
Flags: blocking-aviary1.1?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: