Closed Bug 250488 Opened 21 years ago Closed 21 years ago

open in tabs/middleclicking a bookmarks folder/groupmark is broken

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Version:
1.0 Branch
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

(Keywords: fixed-aviary1.0, regression, Whiteboard: yes, this was broken. yes, it's fixed now. no, wait for a 07/15 build.)

Attachments

(1 file)

patch
924 bytes, patch
bugs
: review+
Details | Diff | Splinter Review
... due to tabbrowser.xml changes in bug 241705. This is similar to bug 250431. Another occurence of browser.mPanelContainer is here: http://lxr.mozilla.org/aviarybranch/source/browser/components/prefwindow/content/pref-navigator.js#115 I'm not sure if that's broken though.
Attached patch patch — — Splinter Review
Comment on attachment 152653 [details] [diff] [review] patch browser.mPanelContainer -> browser.browsers. I didn't know if you'd like to change browser to tabbrowser.
Attachment #152653 - Flags: review?(bugs)
*** Bug 250395 has been marked as a duplicate of this bug. ***
(In reply to comment #0) > Another occurence of browser.mPanelContainer is here: > http://lxr.mozilla.org/aviarybranch/source/browser/components/prefwindow/content/pref-navigator.js#115 > I'm not sure if that's broken though. That still works because it counts the number of child nodes in mTabContainer. There is still one child node for every tab, it's just now they are <vbox>s instead of <browser>s. However it should probably still be fixed to prevent any future breakage, I'll file a bug/attach a patch later on if no one beats me to it.
Is this bug a blocker ? Not having this feature working is killing a big part of tabbed-browsing, isn't it ?
open in tabs fails too.
Flags: blocking-aviary1.0RC1+
Flags: blocking-aviary1.0+
Summary: middleclicking a bookmarks folder/groupmark is broken → open in tabs/middleclicking a bookmarks folder/groupmark is broken
Hard to say what's a blocker as I don't think we have official smoketests... merits a major though.
Severity: normal → major
*** Bug 250608 has been marked as a duplicate of this bug. ***
WFM with Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040709 Firefox/0.9.0+
(In reply to comment #9) > WFM with Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040709 > Firefox/0.9.0+ yes, wfm too.
Sorry to spam this bug, but I tried patch, and it works. Please, check it in ;p
(In reply to comment #0) > ... due to tabbrowser.xml changes in bug 241705. > This is similar to bug 250431. > > Another occurence of browser.mPanelContainer is here: > http://lxr.mozilla.org/aviarybranch/source/browser/components/prefwindow/content/pref-navigator.js#115 > I'm not sure if that's broken though. (In reply to comment #9) > WFM with Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040709 > Firefox/0.9.0+ Well, I'm using the zipped version, and it's a showstopper for me.
WFM using Win32 FireFox 20040711 ZIP version downloaded from BEAST 7/11/2004 13:45 Chicago time.
re cpomment #14. I thought this was an Aviary branch bug. Beast builds are from the trunk.
(In reply to comment #15) > re cpomment #14. I thought this was an Aviary branch bug. Beast builds are > from the trunk. It is an Aviary branch bug for the Mac platform. It is the Aviary branch nighly that is not functioning properly.
Sorry to spam this bug, but for two days, I used this patch on CVS aviary code, and it works without problem under linux. Please, add it to source ;p
Re comment #16. This is not a MAC only bug. The problem exists for windows too in Aviary branch builds. My point was to try to get people to stop posting WFM posts who are using trunk builds. Sorry for bugspam.
Whiteboard: broken on the branch only, still needs checkin
(In reply to comment #18) > Re comment #16. This is not a MAC only bug. The problem exists for windows too > in Aviary branch builds. My point was to try to get people to stop posting WFM > posts who are using trunk builds. > > Sorry for bugspam. Just to be clear, in Comment #9, I posted "WFM" and WAS using a branch build.
Confirming Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712 Firefox/0.9.1+ Zipped Branch Build
Summary: open in tabs/middleclicking a bookmarks folder/groupmark is broken → [aviary] open in tabs/middleclicking a bookmarks folder/groupmark is broken
Whiteboard: broken on the branch only, still needs checkin → stop adding comments other than "checked in finally", thanks
It is confirmed to work on Win32 installer builds and NOT to work on Win32 zip builds.(both AVIARY)
(In reply to comment #21) > It is confirmed to work on Win32 installer builds and NOT to work on Win32 zip > builds.(both AVIARY) Hmm, WFM Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040710 Firefox/0.9.0+, zipped branch build.
Summary: [aviary] open in tabs/middleclicking a bookmarks folder/groupmark is broken → open in tabs/middleclicking a bookmarks folder/groupmark is broken
Version: unspecified → 1.0 Branch
(In reply to comment #22) > (In reply to comment #21) > > It is confirmed to work on Win32 installer builds and NOT to work on Win32 zip > > builds.(both AVIARY) > > Hmm, WFM Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040710 > Firefox/0.9.0+, zipped branch build. Confirm that 07-14-04 Windows Branch (both install & zipped) still have this bug.
(In reply to comment #23) > Confirm that 07-14-04 Windows Branch (both install & zipped) still have this bug. Zip confirmed. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+
Thanks Mike! Checked in 2004-07-14 12:17 PDT. This will be fixed in tomorrow's builds.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: stop adding comments other than "checked in finally", thanks → yes, this was broken. yes, it's fixed now. no, wait for a 07/15 build.
*** Bug 251463 has been marked as a duplicate of this bug. ***
OK just for the record, for those of you confused by the WFM posts that made no sense. Someone on the Mozillaline forums figured out that the bug was NOT present if you had TBE installed. So that explains why some people kept post WFM comments when it still was obvously broken. Sorry for the bugspam but thought people should know, And thought it useful to point out that sometimes in confirming bugs or reporting bugs, listing relevant installed extensions is usefull information to include.
*** Bug 251531 has been marked as a duplicate of this bug. ***
WFM now tested with todays Linux branch: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040715 Firefox/0.9.1+
WFM now tested with todays Linux branch: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040715 Firefox/0.9.1+
WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040715 Firefox/0.9.1+
...and this w4m using 2004-07-15 aviary1.0 (branch) build on mac os x 10.3.4. vrfy'ing as this is also working for others in windows and linux.
Status: RESOLVED → VERIFIED
Keywords: fixed-aviary1.0
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: