250820 - After returning from full screen, rightclick on "navigation toolbar" does not work

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Hussam Al-Tayeb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040710 Firefox/0.9.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040710 Firefox/0.9.0+

After going to fullscreen using F11 and restoring back, you'll find that you
cannot rightclick an customize the navigation toolbar

Reproducible: Always
Steps to Reproduce:
1.open firefox.
2.press F11 to go to full screen
3.press F11 to go back from full screen
4.Right click on navigation toolbar
Actual Results:  
I could not right click on navigation toolbar and customize it.

Expected Results:  
I must be able to right click on navigation toolbar.

Comment 1

[Hussam Al-Tayeb]

This used to work in build 20040709

Comment 2

[mmortal03]

I am not noticing this on Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7)
Gecko/20040710 Firefox/0.9.0+, but what I am noticing is that you cannot
customize now while in full screen, and when you go back, the buttons aren't
small and have text on them, which both were disabled when I went to full screen.

Comment 3

[Raanan Barzel]

Confirming for Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040710 Firefox/0.9.0+

Was not present on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040709 Firefox/0.9.0+

Cusomize is still available on the Menubar.

When a new instance is created, Customize is available on the Toolbar but it
disappears for the Toolbar when F11 is used twice.

When returning from the F11, Icons lose their customized settings (small) and
revert to their original size.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fullscreen-fix-0.patch

The find toolbar doesn't let us blissfully stuff a value in a loop into a
single global variable anymore, expecting it to be the same for each toolbar. 
The patch saves the stuff into per-toolbar temp attributes and restores them
later.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 152905 [details] [diff] [review]
fullscreen-fix-0.patch

r=[e-mail]

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

checked in on aviary.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 250796 has been marked as a duplicate of this bug. ***

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 250865 has been marked as a duplicate of this bug. ***

Comment 9

[Hussam Al-Tayeb]

Ok, I downloaded a tinderbox build and I can verify that the bug's gone.