251017 - software update error dialog broken

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[Steffen Wilberg]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712
Firefox/0.9.1+ (Steffen)

After Ben's checkin from 2004-07-12 02:23, the error dialog doesn't show errors
anymore.

1. In extension mgr, select DOM Inspector and click Update.
2. "no update found" is displayed. Click Details.

Result: An empty errors.xul dialog.
The js console shows this error:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: XStringBundle ::
getString :: line 16"  data: no]

It's this line:
var errorString = xpinstallStrings.getString("error" + items[i].error);
The problem is that items[i].error is "true". But there is no "errortrue" string
in xpinstallStrings.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

.