251165 - F1 on Win/*nix should bring up Help Contents

Status: VERIFIED FIXED

(SeaMonkey :: Help Viewer, defect, P3)

Description

[Steffen Wilberg]

Every single windows app uses F1 to bring up Help.
The respective SeaMonkey bug is bug 88739.

Keys to use are VK_F1 and VK_HELP. The latter only works on Mac:
http://lxr.mozilla.org/aviarybranch/search?string=VK_HELP

Comment 1

[Steffen Wilberg]

Taking.

I don't have a Mac, so I hope this is a recent Mac keyboard:
http://www.internet4classrooms.com/mackeyboard.htm
This means that the help key should work without key modifiers.

Comment 2

[Steffen Wilberg]

Attachment: patch [checked in: comment 6]

Help key for Mac, F1 for other platforms.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 153033 [details] [diff] [review]
patch [checked in: comment 6]

>@@ -58,9 +69,6 @@
>             position="1"
>             accesskey="&helpContents.accesskey;"
>             key="key_openHelp"
>-# Use the Thunderbird content pack if we're building thunderbird. Otherwise use the Firefox content
>-# pack. We should use else instead of elseif to prevent build errors if MOZ_PHOENIX and MOZ_THUNDERBIRD
>-# are not built.

why remove this comment? its still valid here too.

r=me with that comment restored.

Comment 4

[Stefan [:stefanh]]

Actually, I think the correct help key is cmd+? on mac, see bug 88739, comment #71 .

Comment 5

[Steffen Wilberg]

We're going to try VK_HELP. There's no harm done if it doesn't work, as long as
it doesn't break the menu or displays weird characters.

Again, I don't have a Mac, but the link from comment 1 says for the Help key:
"Help - Brings up the Help index for the application you are working in. If you
are in the Finder this brings up Mac OS help."

I'm not sure about Cmd+?. The above mentioned document says: "Cmd+? to launch
the help menu in the Finder". CCing Aaron.

Comment 6

[Steffen Wilberg]

Checked in br & trunk 2004-07-19 07:14-07:15 (with the comment restored).
-> fixed.

Comment 7

[Steffen Wilberg]

Tracy, can you test if the Help key on a Mac brings up Help Contents, like F1
does on Windows and *nix, please?
Builds 07/19 and newer.

Comment 8

[Tracy Walker [:tracy]]

Help key (or cmd+?) does not open Help on Mac OSX with FF0.9+ build
2004-07-19-10-0.9

Comment 5 noted concern about possible menu breakage.  With this build the menu
looks fine.

Comment 9

[Stefan [:stefanh]]

Steffen, there seem to be a mozdev bug dealing with the same problem:
http://bugzilla.mozdev.org/show_bug.cgi?id=5409 It was fixed in June. But it
doesn't looks like this has been checked in to the FF trunk yet.

Comment 10

[Steffen Wilberg]

Stefan, that must have been the code I replaced. VK_HELP was used before, but
that only exists on Mac, and seems to be broken there when looking at comment 8.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Land it now. DTD changes aren't likely to get easy approval after RC1. 

Comment 12

[Steffen Wilberg]

So VK_HELP doesn't work at all. I tried to use Cmd+? but I can't get that to
work either with |key="?" modifiers="control"|. It displays Ctrl+? in the menu,
but it doesn't bring up Help Contents.

Comment 13

[R.J. Keller]

(In reply to comment #12)
> So VK_HELP doesn't work at all. I tried to use Cmd+? but I can't get that to
> work either with |key="?" modifiers="control"|. It displays Ctrl+? in the menu,
> but it doesn't bring up Help Contents.

No, VK_HELP doesn't work at all. Maybe the real solution is making VK_HELP work.
From what it looks like to me, it was first created somewhere in bug 88739.

The bug stefan_h noted does checkin the code you posted, so it does not work on
the Mac.

Comment 14

[Jesse Ruderman]

This might have caused bug 252750, "space goes to help window" (Mac OS X).

Comment 15

[sairuh (rarely reading bugmail)]

could the changes here have caused bug 253603? in that bug, even the menu item
fails to bring up Help Contents (linux and windows trunk).

Comment 16

[Steffen Wilberg]

Bug 252750 will remove the VK_HELP keybinding on Mac for now.
I filed bug 253693 for (re)introducing either VK_HELP or Cmd+? on Mac once the
problems with these are sorted out.

Reducing this bug to Windows/Linux, which is fixed already, see comment 6.