Closed
Bug 251446
Opened 21 years ago
Closed 21 years ago
XBM images with lots of trailing whitespace do not render
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
People
(Reporter: megabyte, Assigned: megabyte)
References
Details
Attachments
(1 file)
|
606 bytes,
patch
|
Biesinger
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
If an XBM image has lots of whitespace after the closing } or ; then the image
doesn't render. This might have something to do with setting the state to
RECV_DONE while there is still lots of data streaming in, so the problem may not
be XBM-specific.
|
||
Comment 1•21 years ago
|
||
yes, I was noticing when looking at the file. there's an "else return
NS_ERROR_FAILURE;" in the file, that can and should probably be removed
|
Assignee | |
Comment 2•21 years ago
|
||
Fix added to bug 251260 patch. I'll need somebody else to check it in.
Depends on: 251260
|
|
Assignee | |
Comment 3•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #155726 -
Flags: superreview?(tor)
Attachment #155726 -
Flags: review?(cbiesinger)
|
|
||
Updated•21 years ago
|
Attachment #155726 -
Flags: review?(cbiesinger) → review+
Attachment #155726 -
Flags: superreview?(tor) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Can somebody check this in so I can more easily make a patch for bug 286897?
Thanks.
|
|
||
Updated•21 years ago
|
Assignee: jdunn → ask
|
|
||
Comment 5•21 years ago
|
||
Checking in modules/libpr0n/decoders/xbm/nsXBMDecoder.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/xbm/nsXBMDecoder.cpp,v <--
nsXBMDecoder.cpp
new revision: 1.14; previous revision: 1.13
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•