Closed
Bug 251465
Opened 21 years ago
Closed 21 years ago
-moz-user-focus: none; makes no sense for XUL
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(2 files)
894 bytes,
patch
|
bryner
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
592 bytes,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
XUL widgets should either take the focus or ignore it. Unlike HTML, they should
never cause a blur to the canvas.
If you want it, the test case I was using had a widget in a menulist; xul.css
defines -moz-user-focus: none; for that widget and therefore when it is clicked
the menulist loses focus.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee: nobody → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 153228 [details] [diff] [review]
Proposed patch
Since * is set to -moz-user-focus: ignore; I thought it would be simplest to
delete all the none; rules.
Please let me know who else I should ask for review from.
Attachment #153228 -
Flags: superreview?(bryner)
Attachment #153228 -
Flags: review?(bryner)
Updated•21 years ago
|
Attachment #153228 -
Flags: superreview?(bryner)
Attachment #153228 -
Flags: superreview+
Attachment #153228 -
Flags: review?(bryner)
Attachment #153228 -
Flags: review+
Assignee | ||
Comment 3•21 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 4•21 years ago
|
||
I missed one occurence when porting most of this to toolkit in Bug 261790
Updated•21 years ago
|
Attachment #167152 -
Flags: review?(mconnor)
Updated•21 years ago
|
Attachment #167152 -
Flags: review?(mconnor) → review+
Comment 5•21 years ago
|
||
Comment on attachment 167152 [details] [diff] [review]
port remaining changes to toolkit (checked in)
toolkit port checked in
Attachment #167152 -
Attachment description: port remaining changes to toolkit → port remaining changes to toolkit (checked in)
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•