251501 - refactor handling of where frames get inserted for child content

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently nsCSSFrameConstructor::GetFrameFor has some ghastly code to figure out
where to insert the frames for child content. It would be much better to replace
this with a method on nsIFrame that determines where child content frames should
be inserted.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The reason I need this, by the way, is because columns need similar delegation
and I couldn't bear to extend GetFrameFor. But this code cleanup feels good on
its own.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: that was the wrong patch...

This is the right patch

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 153255 [details] [diff] [review]
that was the wrong patch...

What's up with ConstructBlock?	You're changing the callers and the signature
without changing the function itself.  I'm assuming that's for some other patch
and you just forgot to remove it.  Other than that this seems fine.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Correct. The ConstructBlock changes are for the actual column frame
implementation and I forgot to edit them out. Thanks.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in