251675 - isInNet's IPv4 address validator nit

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[benc]

"    var test = /^(\\d{1,4})\\.(\\d{1,4})\\.(\\d{1,4})\\.(\\d{1,4})$/(ipaddr);\n"+

you only need "d{1,3}" for octets, they are only 3 digits long.

Comment 1

[Darin Fisher]

patches welcome.

Comment 2

[benc]

I'll do this.

Comment 3

[Boris Zbarsky [:bzbarsky]]

The file that needs fixing here is netwerk/base/src/nsProxyAutoConfig.js; the
isInNet() function.

Comment 4

[Anders Holm]

Attachment: Initial patch

My first patch for Mozilla. Wasn't sure who to set as reviewer, so left blank.

This *should* do the trick though. Any feedback appreciated.

Comment 5

[Benjamin Smedberg]

Comment on attachment 171773 [details] [diff] [review]
Initial patch

Anders, you can check http://www.mozilla.org/owners.html for the list of module
owners. I have marked r?darin for you.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, how did you create the patch? it doesn't look like it will apply - where's
the space in the first column gone?

Comment 7

[Anders Holm]

(In reply to comment #6)
> hm, how did you create the patch? it doesn't look like it will apply - where's

cvs diff -u8pn

> the space in the first column gone?

?? Good question. Checking the original code, each line does start with a double
quote. The diff was pasted into the attached txt file (Initial patch), as
generated. Did I manage to miss anything?

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

> The diff was pasted into the attached txt file 

oh... usually, you'd redirect to a file, like:
  cvs diff -u8p > patch.diff

Comment 9

[Anders Holm]

Attachment: Second try in creating a patch

Second try.. :D

Comment 10

[Darin Fisher]

Comment on attachment 171987 [details] [diff] [review]
Second try in creating a patch

makes sense, r=darin

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171987 [details] [diff] [review]
Second try in creating a patch

sr=bzbarsky

Comment 12

[Boris Zbarsky [:bzbarsky]]

Checked in.  Thank you for the patch, Anders!

Comment 13

[benc]

V/fixed, per lxr.mozilla.org.