Closed Bug 251835 Opened 20 years ago Closed 20 years ago

one line of redundant code in nsXPInstallManager.cpp

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cnst+bmo, Assigned: cnst+bmo)

Details

Attachments

(1 file)

Variable isPageLoading was introduced in version 1.124 (bug 238684), but is no
longer needed in version 1.123 (bug 242111). See the upcoming patch.
Attached patch the patchSplinter Review
Attachment #153487 - Flags: superreview?(jst)
Attachment #153487 - Flags: review?(bsmedberg)
(In reply to comment #0)
> Variable isPageLoading was introduced in version 1.124 (bug 238684), but is no
> longer needed in version 1.123 (bug 242111). See the upcoming patch.

"1.123" should read "1.125". :-)
Status: NEW → ASSIGNED
Comment on attachment 153487 [details] [diff] [review]
the patch

r+sr=jst. Email me if you need help with getting this checked in.
Attachment #153487 - Flags: superreview?(jst)
Attachment #153487 - Flags: superreview+
Attachment #153487 - Flags: review?(bsmedberg)
Attachment #153487 - Flags: review+
Checking in nsXPInstallManager.cpp;
/cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v  <--  nsXPInstallManager.cpp
new revision: 1.126; previous revision: 1.125
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: