251860 - Highlight should be removed (or updated) after a new search started

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P3)

Description

[Nickolay_Ponomarev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040715 Firefox/0.9.1+ (best browser EVAR1!!)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040715 Firefox/0.9.1+

Highlight should be removed (or updated) after a new search started.

Reproducible: Always
Steps to Reproduce:
1. Search for a string, say "bug" using Find Toolbar
2. Click Highlight (all the words "bug" will be highlighted)
3. Wait for the Find Toolbar to close or close it manually (the highlight persists)
4. Start a new search, say for word "Activity"

Actual Results:  
The text in the Find Toolbar is "Activity", the Highlight button is pressed, but
the words higlighted are "bug". To highligh the word "Activity" you have to
click the Highlight button twice.

Expected Results:  
Either "unpress" the Highlight button, or highlight the strings that match the
newly typed "activity" (2nd is preferred).

Comment 1

[Nickolay_Ponomarev]

The side-effect of this bug is that Highlight persistance when switching between
tabs is not sane:
1. Search for something in Tab 1 using Find Toolbar, click Highlight
2. Open a new tab, look at the Highlight button
- it's "pressed" although when you type something, it is not highlighted, and
you have to click the Highlight button twice to highlight it.

(or should it be filed separately?)

Comment 2

[Michael Clackler]

 I almost opened a seperate bug, but it is very close to what you are
describing/requesting Nickolay.

I would suggest that if the "highlight" button is selected while entering text
into the "find" field, the feature should clear any current highlight and
highlight the entire document as you type like it currently does for the first
found item.  I.e. in your example, "bug" would be highlighted when the toolbar
was re-opened, but as soon as you start entering "Activity" in the "Find" field,
the "bug" highlight would clear, and "Activity" would be highlighted in the
document one character at a time as you type.

Currently the "highlight" feature seems to be a "one-shot" selection.  It would
be more usefull if it highlighted the entire document as you typed like it does
for the first found item.  This would eliminate the need to "turn off" the
highlight and then turn it "back on" once you have entered your desired find.

To make this feature complete, bug 251989 should also be fixed.

I think the "highlight" button keeping its state across tabs should probably be
a seperate bug since I feel the state should be tab-specific.  

Comment 3

[Blake Ross]

Fixed on branch.

Don't need to leave open for trunk since I have bug 250231 and all these fixes
will land as part of that.

Comment 4

[:deanis74]

verified using 08/17 branch build