251968 - find -name "*.cpp" | xargs grep "Mode\: IDL" returns results :-(

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

> find -name "*.cpp" | xargs grep "Mode\: IDL"
./xpcom/tests/windows/TestHelloXPLoop.cpp:/* -*- Mode: IDL; tab-width: 4;
indent-tabs-mode: nil; c-basic-offset: 2 -*-
./gfx/src/nsScriptableRegion.cpp:/* -*- Mode: IDL; tab-width: 2;
indent-tabs-mode: nil; c-basic-offset: 2 -*-
./gfx/src/xlib/nsPrintOptionsXlib.cpp:/* -*- Mode: IDL; tab-width: 4;
indent-tabs-mode: nil; c-basic-offset: 2 -*-
./modules/oji/src/nsJVMConfigManagerUnix.cpp:/* -*- Mode: IDL; tab-width: 4;
indent-tabs-mode: nil; c-basic-offset: 4 -*- */
./modules/oji/src/nsJVMConfigManager.cpp:/* -*- Mode: IDL; tab-width: 4;
indent-tabs-mode: nil; c-basic-offset: 4 -*- */
./modules/oji/src/nsJVMAuthTools.cpp:/* -*- Mode: IDL; tab-width: 2;
indent-tabs-mode: nil; c-basic-offset: 2 -*- */
./embedding/browser/activex/src/control_kicker/control_kicker.cpp:/* -*- Mode:
IDL; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
./embedding/browser/activex/src/control_kicker/StdAfx.cpp:/* -*- Mode: IDL;
tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
./embedding/browser/powerplant/source/CWebBrowserCMAttachment.cpp:/* -*- Mode:
IDL; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
./embedding/browser/powerplant/source/EmbedEventHandling.cpp:/* -*- Mode: IDL;
tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
./embedding/browser/powerplant/source/CTextInputEventHandling.cpp:/* -*- Mode:
IDL; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
./netwerk/protocol/http/src/nsHttpAuthManager.cpp:/* -*- Mode: IDL; tab-width:
2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

Comment 1

[Patrick]

This one says [good first bug], however to the newbie it's COMPLETELY unclear
what this bug is about. To that newbie, comment 0 looks totally uncomprehensible
and the summary is also not very helpful as what should be done here...

Funnily enough this bug even made it to
http://www.mozilla.org/contribute/hacking/first-bugs/
Where it's stated "This is a pretty straightforward search and replace, as
described in the bug." 

Comment 2

[Boris Zbarsky [:bzbarsky]]

So to make it more clear, the bug is about C++ files using the wrong Emacs
modeline. The modeline should say "Mode: C++" not "Mode: IDL", for C++ files.

Comment 3

[skaparen]

Attachment: I think this will fix it

i am new to this bug thing m but i think this stuff here is rigth

Comment 4

[skaparen]

Attachment: a patch test

this is my try at a patch

Comment 5

[skaparen]

Comment on attachment 173122 [details]
a patch test 

> find -name "*.cpp" | xargs grep "Mode\: C++"
>./xpcom/tests/windows/TestHelloXPLoop.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./gfx/src/nsScriptableRegion.cpp:/* -*- Mode: C++; tab-width: 2;
>indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./gfx/src/xlib/nsPrintOptionsXlib.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./modules/oji/src/nsJVMConfigManagerUnix.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 4 -*- */
>./modules/oji/src/nsJVMConfigManager.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 4 -*- */
>./modules/oji/src/nsJVMAuthTools.cpp:/* -*- Mode: C++; tab-width: 2;
>indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>./embedding/browser/activex/src/control_kicker/control_kicker.cpp:/* -*- Mode:
>C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/activex/src/control_kicker/StdAfx.cpp:/* -*- Mode: C++;
>tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/powerplant/source/CWebBrowserCMAttachment.cpp:/* -*- Mode:
>C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/powerplant/source/EmbedEventHandling.cpp:/* -*- Mode: C++;
>tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/powerplant/source/CTextInputEventHandling.cpp:/* -*- Mode:
>C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./netwerk/protocol/http/src/nsHttpAuthManager.cpp:/* -*- Mode: C++; tab-width:
>2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

Comment 6

[skaparen]

Comment on attachment 173122 [details]
a patch test 

>> find -name "*.cpp" | xargs grep "Mode\: C++"
>./xpcom/tests/windows/TestHelloXPLoop.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./gfx/src/nsScriptableRegion.cpp:/* -*- Mode: C++; tab-width: 2;
>indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./gfx/src/xlib/nsPrintOptionsXlib.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./modules/oji/src/nsJVMConfigManagerUnix.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 4 -*- */
>./modules/oji/src/nsJVMConfigManager.cpp:/* -*- Mode: C++; tab-width: 4;
>indent-tabs-mode: nil; c-basic-offset: 4 -*- */
>./modules/oji/src/nsJVMAuthTools.cpp:/* -*- Mode: C++; tab-width: 2;
>indent-tabs-mode: nil; c-basic-offset: 2 -*- */
>./embedding/browser/activex/src/control_kicker/control_kicker.cpp:/* -*- Mode:
>C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/activex/src/control_kicker/StdAfx.cpp:/* -*- Mode: C++;
>tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/powerplant/source/CWebBrowserCMAttachment.cpp:/* -*- Mode:
>C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/powerplant/source/EmbedEventHandling.cpp:/* -*- Mode: C++;
>tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./embedding/browser/powerplant/source/CTextInputEventHandling.cpp:/* -*- Mode:
>C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
>./netwerk/protocol/http/src/nsHttpAuthManager.cpp:/* -*- Mode: C++; tab-width:
>2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

Comment 7

[skaparen]

Attachment: patch

i think this is rigth

Comment 8

[Boris Zbarsky [:bzbarsky]]

That's not a patch, is it?  To create a patch, use "cvs diff -up8 file1 file2 ..."

Comment 9

[Andreas Lange]

Attachment: Fix the last IDL line

Tinkered a bit with a one-liner to fix this, just to find out that the grep now
finds only one file. Seems the other files got fixed alread (in license
updates, perhaps?)

Comment 10

[Boris Zbarsky [:bzbarsky]]

Thanks!

Checked that in.