252133 - in sidebar and bm manager new items should be added below selected item, not above. inconsistent behavior across bookmarks manager, sidebar, and menu.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asa Dotzler [:asa]]

There is an inconsistency between the menu new item additions and the bookmarks
manager and sidebar new item additions. In the menus the new item is correctly
added _below_ the selected item (with the exception of menus which is a bug). In
the Bookmarks Manager and the Bookmarks Sidebar, new items are incorrectly added
above the selected item. Tested with the latest aviary branch build on windows XP.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

RDFContainer seems to inconsistently renumber when inserting an element at a
position that's already occupied by another -- if it's the last element, it gets
pushed forward so that the "new" thing comes before the last element. 
Otherwise, it correctly inserts after the thing.

I'm going to check in a patch to always add new items at the end of the parent
container, regardless of the position of the selected item -- though it's not
ideal, it's better than having the behaviour be wildly inconsistent.  I'll take
a look at doing the real fix with RDFContainer.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

patch in on aviary, trunk soon

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=AviaryBranchTinderbox&branch=AVIARY_1_0_20040515_BRANCH&cvsroot=/cvsroot&date=explicit&mindate=1090724100&maxdate=1090724640&who=vladimir%25pobox.com

Comment 3

[Tracy Walker [:tracy]]

As seen on 0.9+ branch builds from 0726 items are now added at the end of the
list in the parent container. 

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

bandaid applied to branch and trunk

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 252133-new-bm-items-in-wrong-place-0.patch

This is a partial backout of the previous patch, and a small fix.  With this,
everything seems to work like it should -- items are always getting added to
the end.  So, I'd like to get this in.

Comment 6

[Peter van der Woude [:Peter6]]

probably causing regression bug 264031

Comment 7

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change