252143 - Leak in nsScreenGtk::Init of gdk_property_get() result

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Crispin Flowerday (not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040716 Galeon/1.3.16.99
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040716 Galeon/1.3.16.99

Valgrind picked up a tiny leak in nsScreenGtk::Init():

==17899== 96 bytes in 1 blocks are definitely lost in loss record 10531 of 11630
==17899==    at 0x3414A101: malloc (vg_replace_malloc.c:109)
==17899==    by 0x34BAC0B6: g_malloc (in /usr/lib/libglib-2.0.so.0.400.4)
==17899==    by 0x349472DE: gdk_property_get (in /usr/lib/libgdk-x11-2.0.so.0.400.3)
==17899==    by 0x35BC5D7F: nsScreenGtk::Init() (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libgfx_gtk.so)
==17899==    by 0x35BC60FE: nsScreenManagerGtk::EnsureInit() (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libgfx_gtk.so)
==17899==    by 0x35BC62DF: nsScreenManagerGtk::GetPrimaryScreen(nsIScreen**)
(in /space/opt/mozilla/lib/mozilla-1.8a3/components/libgfx_gtk.so)
==17899==    by 0x35BB7D60: nsDeviceContextGTK::Init(void*) (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libgfx_gtk.so)
==17899==    by 0x35CC5888: nsBaseWidget::BaseCreate(nsIWidget*, nsRect const&,
nsEventStatus (*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*, nsIToolkit*,
nsWidgetInitData*) (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libwidget_gtk2.so)
==17899==    by 0x35CB7FEA: nsWindow::NativeCreate(nsIWidget*, void*, nsRect
const&, nsEventStatus (*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*,
nsIToolkit*, nsWidgetInitData*) (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libwidget_gtk2.so)
==17899==    by 0x35CB4551: nsWindow::Create(void*, nsRect const&, nsEventStatus
(*)(nsGUIEvent*), nsIDeviceContext*, nsIAppShell*, nsIToolkit*,
nsWidgetInitData*) (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libwidget_gtk2.so)
==17899==    by 0x363C193D: nsWebBrowser::Create() (in
/space/opt/mozilla/lib/mozilla-1.8a3/components/libwebbrwsr.so)


The gtk docs for gdk_property_get() say that you must g_free() the value filled
into the last argument (in this case the workareas)


Reproducible: Always
Steps to Reproduce:

Comment 1

[Crispin Flowerday (not receiving bug mail)]

Attachment: Simple patch to fix the leak

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

bug status -> new

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 153683 [details] [diff] [review]
Simple patch to fix the leak

r=caillon.  Thanks for finding this.

Comment 4

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!

Comment 5

[Crispin Flowerday (not receiving bug mail)]

*** Bug 250804 has been marked as a duplicate of this bug. ***

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 268374 has been marked as a duplicate of this bug. ***