252224 - wrong favicon for bookmarks

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Michaël Arnauts]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040717 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040717 Firefox/0.9.1+

i've seen that there were recently made a lot of favicon-fixed to aviary. Now,
most of them seems fixed, however, there is still one that isn't.
As you can see in the screenshots i will attach, the icon for "The Burning Edge"
is a google one. After i click it, it becomes a FireFox one. When i close
firefox and restart it, i is back a google icon.

Reproducible: Always
Steps to Reproduce:
1. start my firefox
2. look at the google icon in front of "The Burning Edge"
3. click "The Burning Edge"
4. look how it changes to a FireFox icon
Actual Results:  
icon changed but it wasn't saved

Expected Results:  
save it

Comment 1

[Michaël Arnauts]

Attachment: before i click the icon

Comment 2

[Michaël Arnauts]

Attachment: after i click the icon

Comment 3

[Frederic Bezies]

Duplicate of bug 174265 ?

Comment 4

[Michaël Arnauts]

my build is 20040717, and that's from the build where that bug is fixed, so it
can't be a duplicate since that one should be fixed.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

There was a bug in the 20040717 build that caused updated favicons to sometimes
not get stored.  Please try with a more recent one.

Comment 6

[Michaël Arnauts]

hmm, i will have to wait till there comes a linux build then, because the
20040719 hasn't a linux build...

Comment 7

[Mike Connor [:mconnor]]

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-0.9/ has linux
nightlies from today.

Comment 8

[Michaël Arnauts]

ok, sorry, i tried 200407220 and there it is fixed, so this bug can be marked
invalid

Comment 9

[Michaël Arnauts]

hmm, no wait, that burning edge bug issue is fixed, so i guess the icons are
saved correctly now, but can somebody try to bookmark www.dot.tk and see if that
favicon is saved when you click it? i can see the icon in the adressbar, but it
doesn't appear in the bookmark menu. when i click my own site
(www.maycosplace.tk), i get a empty favicon (so not a blank page, just a
transparant empty favicon).

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #9)
> hmm, no wait, that burning edge bug issue is fixed, so i guess the icons are
> saved correctly now, but can somebody try to bookmark www.dot.tk and see if that
> favicon is saved when you click it? i can see the icon in the adressbar, but it
> doesn't appear in the bookmark menu. when i click my own site
> (www.maycosplace.tk), i get a empty favicon (so not a blank page, just a
> transparant empty favicon).

Your site has an invalid favicon; or rather, www.maycosplace.tk/favicon.ico ends
up redirecting back to your home page.  Mozilla tries to prase this as an image
and fails, but that failure is (currently) not being handled in any way... so
you get a blank favicon.  I've got some ideas on how to prevent this from
happening for bookmarks at least.

resolving this bug, bug 252540 for the other issue.

Comment 11

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change