Closed
Bug 252289
Opened 20 years ago
Closed 20 years ago
M18a2 topcrash in safefileoutputstream [@ nsSafeFileOutputStream::Init]
Categories
(Core :: Networking: File, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: mvl, Assigned: dwitte)
Details
(Keywords: crash, fixed-aviary1.0, topcrash)
Crash Data
Attachments
(1 file, 2 obsolete files)
2.50 KB,
patch
|
mvl
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=nsSafeFileOutputStream%3A%3AInit stacks point to: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/base/src/nsFileStreams.cpp&rev=1.64&root=/cvsroot&mark=503#503 Called from http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/cookie/src/nsCookieService.cpp&rev=1.38&mark=1039#1039 Looks like mCookieFile is null. Should not happen, unless there is no profile. But when is this code called without a profile? anyway, a null check somewhere should fix this.
Updated•20 years ago
|
Severity: normal → critical
Assignee | ||
Comment 1•20 years ago
|
||
check in the stream init, to make it consistent with nsFileOutputStream.
Assignee | ||
Comment 2•20 years ago
|
||
cookies is called without a profile at startup, in seamonkey anyway (not sure about fx). we initialize it for some silly thing before the profile manager comes up. i can't remember why, but i hate it. i don't know why we haven't seen this crash ourselves.
Assignee: darin → dwitte
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #153828 -
Flags: superreview?(darin)
Attachment #153828 -
Flags: review?(mvl)
Assignee | ||
Updated•20 years ago
|
Attachment #153829 -
Flags: superreview?(darin)
Attachment #153829 -
Flags: review?(mvl)
Reporter | ||
Comment 3•20 years ago
|
||
Comment on attachment 153828 [details] [diff] [review] nullcheck file >- NS_ENSURE_STATE(mTargetFile); Hmm, maybe you should leave that check there. It never hurts to be sure. A bad consumer can call Finish() even when Init() failed. Other checks is good. r=mvl
Attachment #153828 -
Flags: review?(mvl) → review+
Reporter | ||
Comment 4•20 years ago
|
||
Comment on attachment 153829 [details] [diff] [review] nullcheck mCookieFile too >+ NS_ENSURE_ARG(mCookieFile); NS_ENSURE_STATE might be more appropiate. It isn't an arg. Also, if you know that it will warn on startup because cookies start when there is no profile, is it worth warning?
Assignee | ||
Comment 5•20 years ago
|
||
you're right, it's not. i'll make it an |if| check instead.
Comment 6•20 years ago
|
||
please post one final patch for this bug, thanks!
Comment 7•20 years ago
|
||
Comment on attachment 153828 [details] [diff] [review] nullcheck file i agree with mvl, keep the NS_ENSURE_STATE(mTargetFile) shouldn't mTargetFileExists be initialized in the ctor?
Attachment #153828 -
Flags: superreview?(darin) → superreview-
Comment 8•20 years ago
|
||
Comment on attachment 153829 [details] [diff] [review] nullcheck mCookieFile too minus in favor of NS_ENSURE_STATE as suggested by mvl.
Attachment #153829 -
Flags: superreview?(darin) → superreview-
Comment 9•20 years ago
|
||
Adding topcrash info for tracking, this is a topcrasher with Mozilla 1.8 alpha2.
Keywords: topcrash
Summary: topcrash in safefileoutputstream [@ nsSafeFileOutputStream::Init] → M18a2 topcrash in safefileoutputstream [@ nsSafeFileOutputStream::Init]
Assignee | ||
Updated•20 years ago
|
Attachment #153829 -
Flags: review?(mvl)
Assignee | ||
Comment 10•20 years ago
|
||
Attachment #153828 -
Attachment is obsolete: true
Attachment #153829 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #153931 -
Flags: superreview?(darin)
Comment 11•20 years ago
|
||
Comment on attachment 153931 [details] [diff] [review] here we go sr=darin
Attachment #153931 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Updated•20 years ago
|
Attachment #153931 -
Flags: review?(mvl)
Reporter | ||
Updated•20 years ago
|
Attachment #153931 -
Flags: review?(mvl) → review+
Assignee | ||
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•20 years ago
|
Whiteboard: needed-aviary1.0
Assignee | ||
Updated•20 years ago
|
Keywords: fixed-aviary1.0
Whiteboard: needed-aviary1.0
Updated•13 years ago
|
Crash Signature: [@ nsSafeFileOutputStream::Init]
You need to log in
before you can comment on or make changes to this bug.
Description
•