Closed
Bug 252435
Opened 21 years ago
Closed 21 years ago
get rid of *WithConversion in chrome registry
Categories
(Core Graveyard :: RDF, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha3
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
6.15 KB,
patch
|
benjamin
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
this is only used for stuff passed to GetResource, which uses UTF-8 strings, so
I'm changing that to use AppendUTF16toUTF8
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #153891 -
Flags: review?(bsmedberg)
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha3
Updated•21 years ago
|
Attachment #153891 -
Flags: review?(bsmedberg) → review+
Assignee | ||
Updated•21 years ago
|
Attachment #153891 -
Flags: superreview?(darin)
Comment 2•21 years ago
|
||
Comment on attachment 153891 [details] [diff] [review]
patch
sr=darin
ok, sure.. i guess it makes sense for RDF URNs to be UTF8. hopefully, we don't
actually have any non-ASCII URNs in any of our serialized RDF documents.
though they would have been smashed by AppendWithConversion, ISO-Latin-1
characters would have managed ok. oh well.. hopefully, this is not something
we need to worry about.
Attachment #153891 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Comment 3•21 years ago
|
||
Checking in chrome/src/nsChromeRegistry.cpp;
/cvsroot/mozilla/chrome/src/nsChromeRegistry.cpp,v <-- nsChromeRegistry.cpp
new revision: 1.304; previous revision: 1.303
done
Checking in rdf/chrome/src/nsChromeRegistry.cpp;
/cvsroot/mozilla/rdf/chrome/src/nsChromeRegistry.cpp,v <-- nsChromeRegistry.cpp
new revision: 1.306; previous revision: 1.305
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•