252483 - Create an account wizard for RSS

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Scott MacGregor]

I think we are going to want to set up a rss.rdf file and some account wizard
chrome for creating an RSS News & Blog Account. 

We should then get rid of the code in forumzilla.js which force creates a News &
Blog account when you first start up the app. This way only folks that use the
RSS stuff will get an RSS account.

The wizard may be as simple as only having a single panel asking you for the
name of the account.

Eventually, maybe we can leverage David's "deferred inbox" code to allow a user
to defer RSS feeds into a local folder, hiding the actual account from the
folder pane....

Comment 1

[Scott MacGregor]

Attachment: the fix [Checkin: Comment 3]

Comment 2

[Scott MacGregor]

Comment on attachment 153974 [details] [diff] [review]
the fix
[Checkin: Comment 3]

David, this patch does a couple of things:

1) adds a rss.rdf ispdata file so we can dynamically add an RSS account menu
item to the account wizard.

2) The account wizard was requiring the identity page for all account types.
Then you could customize what panels to skip after the identity page. I moved
all the customization logic out of the identity page and into the account type
page so that the RSS rdf file could specify the ability to skip the identity
page. You'll also see lots of "if identity" checks in AccountWizard.js when we
actually create the account/server/identity prefs because my changes no longer
require you to actually have an identity when filling out the wizard.

3) Eliminate forumzilla.xul and forumzilla.js from the build. All of the
account creation stuff happens from the wizard now. 

4) Instead of relying on forumzilla.js to get the incoming server for
FeedItem.js and subscription.js, pass in the RSS server from the mail front end
when invoking the subscription dialog. Set this as a property on the Feed for
everyone to use instead of calling the obsolete getIncomingServer.

Comment 3

[Scott MacGregor]

this is checked in. 

There's still one remaining problem. You can't create more than one account
because all RSS accounts have the same user name (nobody), host name (rss) and
server name (rss). I'm not sure how to (or if we want to) fix that yet. 

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050728 SeaMonkey/1.0a]
(nightly) (W98SE)

Validating first page of account wizard
{{
Warning: assignment to undeclared variable skipArray
Source File: chrome://messenger/content/aw-accounttype.js
Line: 93
}}

From the patch, <aw-identity.js> should have the same bug.

Adding a |var | should fix it/them.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> From the patch, <aw-identity.js> should have the same bug.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.10) Gecko/20050727] (-08 nightly)
(W98SE)

shows the warning in that other file.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> From the patch, <aw-identity.js> should have the same bug.

My mistake: the patch moved the code from one file to the other.

Anyway, I'll add a patch in this bug...

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <aw-accounttype.js> |var| addition [Checkin: Comment 9]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050217] (<-- 1.8b1 !)
(W98SE)

Fixes the warning,
and a few whitespace cleanups.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 191057 [details] [diff] [review]
(Bv1) <aw-accounttype.js> |var| addition
[Checkin: Comment 9]

The |var| addition part has already been checked in as part of
{ 1.24	bugzilla%standard8.demon.co.uk	2005-08-27 10:48	 	Fix bug 216245 subscribe/account wizard for newsgroups forgets account name. r=mnyromyr,sr=bienvenu }

'approval-branch-1.8.1=?': 
Trivial JS code cleanup, no risk. (To keep files in sync only.)

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 191057 [details] [diff] [review]
(Bv1) <aw-accounttype.js> |var| addition
[Checkin: Comment 9]

Checked in on trunk & branch. On Trunk I reviewed the first bit as the var had already been added by another bug fix.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 191057 [details] [diff] [review]
(Bv1) <aw-accounttype.js> |var| addition
[Checkin: Comment 9]

'approval1.8.0.3=?':
Trivial U.I. code cleanup, no risk.