Closed
Bug 252541
Opened 20 years ago
Closed 20 years ago
nsString::IsASCII and IsSpace redundant
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha3
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
|
9.64 KB,
patch
|
darin.moz
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
IsSpace can be replaced by nsCRT::IsAsciiSpace (they have both the same // XXX i18n comment... and check for the same characters) IsASCII can be replaced by the global IsASCII function provided by nsReadableUtils.h. there's also a version in nsCRT, but that takes char/PRUnichar buffers, not string objects.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #154090 -
Flags: review?(darin)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha3
|
||
Updated•20 years ago
|
Attachment #154090 -
Flags: review?(darin) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #154090 -
Flags: superreview?(dbaron)
Attachment #154090 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Comment 2•20 years ago
|
||
checked in
|
|
Assignee | |
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•