Closed
Bug 252688
Opened 21 years ago
Closed 21 years ago
Move feeds.rdf and feeditems.rdf into the rss account directory
Categories
(MailNews Core :: Feed Reader, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mscott, Assigned: mscott)
Details
Attachments
(1 file)
|
14.84 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Each RSS account has its own feed and items data source.
This will also make it easy to generically remove the RSS account from the
account manager without leaving stale data source data behind. By being in the
account directory, when the account is removed, so is the RSS data for that account.
| Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.8
| Assignee | ||
Comment 1•21 years ago
|
||
| Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 154036 [details] [diff] [review]
the fix
David, this patch adds two methods to nsIRssIncomingServer for getting the file
path for feeds.rdf and feedItems.rdf for an rss server.
I also had to make a change to nsLocalMailFolder.cpp to make it ignore
"feeds.rdf" and "feeditems.rdf" when figuring out which files are folders. Is
there a better place to do that besides taining nsLocalMailFolder? I don't
think there is.
One more thing..are we happy with the names 'feeds.rdf' and 'feeditems.rdf'. If
we want to change them, now's the time.
Attachment #154036 -
Flags: superreview?(bienvenu)
Comment 3•21 years ago
|
||
Comment on attachment 154036 [details] [diff] [review]
the fix
Can you just add a helper function that both GetFeedItemsDataSourcePath and
GetSubscriptionsDataSourcePath call, which just appends the passed in string
to the file name, i.e., feeds.rdf or feeditems.rdf? sr=bienvenu with that
change.
Attachment #154036 -
Flags: superreview?(bienvenu) → superreview+
| Assignee | ||
Updated•21 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird0.8 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•