252730 - [FIX]Images should not animate if none of the proxies have a listener

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Basically, we should only count proxies that would deliver notifications someone
cares about.

David, I talked to pav about this on IRC today.  In short, he'd prefer that the
imgRequest not point to the listeners directly, the lock stuff is irrelevant
(and he's working on removing it), and pav would rather the imgRequest pointed
to all its proxies.

Given those constraints, we decided the best thing is to have the imgRequest not
just get the count of the proxy array but check the individual proxies to see
whether it finds one with a listener.  If it does, it animates.

The chances of an imgRequest having a lot of listener-less proxies is pretty
low, so the linear search seems OK.

If done right this will fix bug 239197 too.  I may remove a large chunk of the
changes for bug 210001 also; I need to decide whether the gymnastics I may have
to do in nsImageLoadingContent (which just wants to listen for image completion
when it has an mPendingRequest) are worth that.  On the bright side, using the
clone() stuff we have for the image frame _could_ simplify the image loading
content code a good bit... (I may push off all of that stuff into a separate bug
if it starts to bog me down; this bug is going to focus on making changes such
that bug 236889 can land).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 154125 [details] [diff] [review]
Patch

I decided the bug 210001 code wasn't worth messing with -- when the secondary
request loads we need to notify the image frame somehow, which makes life very
complicated unless all notifications go through the nsImageLoadingContent
object.

This last could clone() requests as needed when observers are added/removed,
but that seems like overkill...

Comment 3

[Stuart Parmenter]

Comment on attachment 154125 [details] [diff] [review]
Patch

r=

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.