252732 - Add call parentheses to GetScriptGlobalObject and remove trailing whitespace in nsEventStateManager.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

Shows how often this bit of the code gets called! I've added the parentheses to
the relevant line and used my editor to automatically remove all trailing
whitespace in the upcoming patch (no other changes).

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Johnny Stenback (:jst)]

Wanna attach a diff -w version here for reviewers only?

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: cvs diff -w

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 154067 [details] [diff] [review]
cvs diff -w

-  nsCOMPtr<nsIDOMWindowInternal>
domwin(do_QueryInterface(doc->GetScriptGlobalObject));
+  nsCOMPtr<nsIDOMWindowInternal>
domwin(do_QueryInterface(doc->GetScriptGlobalObject()));

Wow, I bet this wouldn't even compile... this code is inside an #ifdef
DEBUG_DOCSHELL_FOCUS, which I guess noone really defines any more...

r+sr=jst for this and all the cleanup you did.

Comment 5

[Jonathan Watt [:jwatt]]

Thanks for the super fast review. Maybe the DEBUG_DOCSHELL_FOCUS stuff should
just be removed, it only appears in content/events/src/nsEventStateManager.cpp
and docshell/base/nsDocShell.cpp

Comment 6

[timeless]

given that problems do happen near that stuff, we should probably resurrect it 
instead.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 154066 [details] [diff] [review]
patch

this sr request seems obsolete now...

Comment 8

[Aaron Leventhal]

This patch makes it amazingly more difficult for me to get my changes in bug
250006 to merge in.