252783 - text input doesn't consider letter-spacing for sizing

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Steven Willis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Webimpala/0.9.1 (Firefox/0.9.1)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Webimpala/0.9.1 (Firefox/0.9.1)

A text form input seems to ignore the "letter-spacing" style information when
calculating it's width. It seems to calculate the width based on there being no
letter-spacing. Now I don't know if style information is supposed to be
considered when picking a size for a form element, but setting the "font-size"
does affect the size of an input. The following html snippet gives shows what I
mean:

<p>The following text input has a size of 10, a maxlength of 10, and a
letter-spacing of 0em. Ten characters fit inside the input nicely.</p>
<input type="text" size="10" maxlength="10" style="letter-spacing: 0em">

<p>The following text input has a size of 10, a maxlength of 10, and a
letter-spacing of 1em. The letter-spacing is ignored when calculating the width
of the input, as you can see by typing 10 characters and having it scroll.</p>
<input type="text" size="10" maxlength="10" style="letter-spacing: 1em">

<p>The following text input has a size of 10, a maxlength of 10, and a font-size
of 20pt. Here, some style information (font-size) *is* used to calculate the
input's width (and height in this case).</p>
<input type="text" size="10" maxlength="10" style="font-size: 20pt">

Like I said, I don't know how much style information is supposed to be used when
calculating the size of an input, but it seems that since some information is
used then it might be best to be consistent... (of course this is probably one
of those things left up to the user-agents I'm sure)

Reproducible: Always
Steps to Reproduce:
1. Specify a size of 10 on a text input form element
2. Give the input a style consiting of "letter-spacing: 1em"
3. Check the resulting page
Actual Results:  
You won't be able to fit 10 of characters into the input without it scrolling to
the right.


Expected Results:  
I expected that the input would be wider to accomodate the extra letter-spacing.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Taking bug, this is a trivial fix if we want to do it...

Comment 3

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 4

[Mats Palmgren (inactive)]

Attachment: Screenshot with "Patch rev. 1"

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 154138 [details] [diff] [review]
Patch rev. 1

>+  // Increment width with cols * letter-spacing.
>+  {
>+    const nsStyleText* textStyle = GetStyleText();
>+    if (eStyleUnit_Coord == textStyle->mLetterSpacing.GetUnit()) {
>+      nscoord letterSpacing = textStyle->mLetterSpacing.GetCoordValue();

Why have a |const nsStyleText*| varable when you could have a |const
nsStyleCoord&| variable, e.g.:

const nsStyleCoord& lsCoord = GetStyleText()->mLetterSpacing;
etc.

With that, sr=dbaron

Comment 6

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Updated as suggested in comment 5

Comment 7

[Mats Palmgren (inactive)]

Comment on attachment 154151 [details] [diff] [review]
Patch rev. 2

Moving sr=dbaron from comment 5

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 154151 [details] [diff] [review]
Patch rev. 2

r=bzbarsky

Comment 9

[Mats Palmgren (inactive)]

FYI, I did check all the other form controls and they seem to work except
<input type="file"> which I filed bug 252863 on.

Comment 10

[Mats Palmgren (inactive)]

Checked in to trunk 2004-08-07 15:04 PDT

-> FIXED