252788 - GTK2 file picker patch fails to build on AIX

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Philip K. Warren]

The latest patch for the GTK2 file picker fails to build on AIX with the
following error messages:

"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 69.1: 1540-0033 (S) A typedef declaration must declare a name.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 70.1: 1540-0033 (S) A typedef declaration must declare a name.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 82.18: 1540-0001 (S) A typedef must not have an initializer.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 91.16: 1540-0001 (S) A typedef must not have an initializer.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 92.16: 1540-0001 (S) A typedef must not have an initializer.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 93.16: 1540-0001 (S) A typedef must not have an initializer.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 94.22: 1540-0040 (S) The text "*" is unexpected.  "GtkFileFilter" may be
undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 95.16: 1540-0001 (S) A typedef must not have an initializer.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 96.16: 1540-0001 (S) A typedef must not have an initializer.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 100.2: 1540-0040 (S) The text "_gtk_file_chooser_get_filename" is
unexpected.  "_gtk_file_chooser_get_filename_fn" may be undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 102.2: 1540-0040 (S) The text "_gtk_file_chooser_set_select_multiple" is
unexpected.  "_gtk_file_chooser_set_select_multiple_fn" may be undeclared or
ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 103.2: 1540-0040 (S) The text "_gtk_file_chooser_set_current_name" is
unexpected.  "_gtk_file_chooser_set_current_name_fn" may be undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 104.2: 1540-0040 (S) The text "_gtk_file_chooser_add_filter" is unexpected.
 "_gtk_file_chooser_add_filter_fn" may be undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 105.2: 1540-0040 (S) The text "_gtk_file_filter_new" is unexpected. 
"_gtk_file_filter_new_fn" may be undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 106.2: 1540-0040 (S) The text "_gtk_file_filter_add_pattern" is unexpected.
 "_gtk_file_filter_add_pattern_fn" may be undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 107.2: 1540-0040 (S) The text "_gtk_file_filter_set_name" is unexpected. 
"_gtk_file_filter_set_name_fn" may be undeclared or ambiguous.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 219.69: 1540-0063 (S) The text ")" is unexpected.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 478.60: 1540-0063 (S) The text ")" is unexpected.
"/home/pkw/sb/mozilla/trunk-devel/mozilla/widget/src/gtk2/nsFilePicker.cpp",
line 138.73: 1540-0063 (S) The text "func" is unexpected.

I will post a patch which fixes the problem.

Comment 1

[Philip K. Warren]

Attachment: Patch v1

Very simple patch which fixes the problem.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 154122 [details] [diff] [review]
Patch v1

r=me for the changes, but it should probably be:

  typedef struct _GtkFileChooser GtkFileChooser;
  typedef struct _GtkFileFilter GtkFileFilter;

(note the leading '_')

Comment 3

[Philip K. Warren]

Comment on attachment 154122 [details] [diff] [review]
Patch v1

Chris: Can you sr this patch? I'll add the changes suggested by caillon.

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 154122 [details] [diff] [review]
Patch v1

Yeah, you should fix the underscores but it's fine other than that.

Comment 5

[Philip K. Warren]

Fixed.

Checking in nsFilePicker.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsFilePicker.cpp,v  <--  nsFilePicker.cpp
new revision: 1.2; previous revision: 1.1
done