252795 - Folder/Newsgroup Properties dialog has no access keys

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Stefan Borggraefe]

Comment 1

[Stefan Borggraefe]

Attachment: Patch diff -uw

Comment 2

[Stefan Borggraefe]

Attachment: Patch diff -u

Comment 3

[Stefan Borggraefe]

Comment on attachment 154127 [details] [diff] [review]
Patch diff -u

Aaron, can you review this patch? Thanks! :-)

Comment 4

[Aaron Leventhal]

Comment on attachment 154126 [details] [diff] [review]
Patch diff -uw

Questions:
- Can your patch also cover Thunderbird?
- Why not use "D" for the second "Download now". Will they ever both appear at
the same time? W is okay there, but it's harder to remember than D.

Comment 5

[Aaron Leventhal]

Comment on attachment 154127 [details] [diff] [review]
Patch diff -u

r=aaronlev if you resolve my previous questions. It would be great to have the
same fix for Thunderbird (assuming their dialogs are similar)

Comment 6

[Stefan Borggraefe]

(In reply to comment #4)
> (From update of attachment 154126 [details] [diff] [review])
> Questions:
> - Can your patch also cover Thunderbird?

This patch fixes both Seamonkey and Thunderbird, because the Folder Properties
dialog wasn't forked.

> - Why not use "D" for the second "Download now". Will they ever both appear at
> the same time? W is okay there, but it's harder to remember than D.

Ah, right you are. :-) These two buttons are never displayed at the same time
(one is for IMAP folders, the other for newsgroups). I'll change the access key
of the second "Download Now"-button to "D" before checkin.

Comment 7

[Stefan Borggraefe]

Comment on attachment 154127 [details] [diff] [review]
Patch diff -u

Scott, can you sr this? Thanks! :-)

Comment 8

[Stefan Borggraefe]

Fix checked in. Thanks for the reviews! :-)