252833 - HTTP Auth website makes wallet crash - Trunk [@ SINGSIGN_PromptUsernameAndPassword]

Status: VERIFIED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Frank Wein [:mcsmurf]]

reproducable with a current cvs trunk build on win2k

To reproduce:
1. Go to
http://www.heise.de/newsticker/foren/write.shtml?msg_id=6106267&forum_id=61371
(a website which requires 401 HTTP AUTH)
2. Watch crash!


Stacktrace:
SINGSIGN_PromptUsernameAndPassword(const unsigned short * 0x00000000, const
unsigned short * 0x026c0ed8, unsigned short * * 0x0012f974, unsigned short * *
0x0012f978, const char * 0x0012f6dc, nsIPrompt * 0x026c8928, int * 0x0012f964,
unsigned int 0x00000002) line 2726 + 4 bytes
nsSingleSignOnPrompt::PromptUsernameAndPassword(nsSingleSignOnPrompt * const
0x026b18b8, const unsigned short * 0x00000000, const unsigned short *
0x026c0ed8, const unsigned short * 0x0012f898, unsigned int 0x00000002, unsigned
short * * 0x0012f974, unsigned short * * 0x0012f978, int * 0x0012f964) line 591
+ 55 bytes
nsHttpChannel::PromptForIdentity(nsHttpChannel * const 0x00000000, const char *
0x0012fa80, const char * 0x026c0ed8, int 0x00000050, int 0x00000000, const char
* 0x00000029, const char * 0x0012fb40, unsigned int 0x0000000d,
nsHttpAuthIdentity & {...}) line 2468
nsHttpChannel::GetCredentialsForChallenge(nsHttpChannel * const 0x00000000,
const char * 0x0012fb98, const char * 0x0012fb40, int 0x00000000,
nsIHttpAuthenticator * 0x0250f850, nsCString & {...}) line 2266
nsHttpChannel::GetCredentials(nsHttpChannel * const 0x00000000, const char *
0x026899f8, int 0x00000000, nsCString & {...}) line 2124 + 26 bytes
nsHttpChannel::ProcessAuthentication(nsHttpChannel * const 0x00000000, unsigned
int 0x00000191) line 2072 + 13 bytes
nsHttpChannel::ProcessResponse(nsHttpChannel * const 0x00000000) line 752 + 8 bytes
nsHttpChannel::OnStartRequest(nsHttpChannel * const 0x0250a430, nsIRequest *
0x02343c80, nsISupports * 0x00000000) line 3547 + 8 bytes
nsInputStreamPump::OnStateStart(nsInputStreamPump * const 0x00000000) line 383
nsInputStreamPump::OnInputStreamReady(nsInputStreamPump * const 0x6965682e,
nsIAsyncInputStream * 0x642e6573) line 345
SHELL32! 7777772f()

Looks like change from Bug 247417, so CCing mvl

Comment 1

[Frank Wein [:mcsmurf]]

New steps to reproduce (old didnt work):
1. Go to
http://www.heise.de/newsticker/foren/go.shtml?read=1&msg_id=6106267&forum_id=61371
2. Click on "Beantworten"
3. Watch crash

Comment 2

[Hermann Schwab]

I´ve got an account over there, use session cookies, but may be one is
permanent, so I didn´t succed producing the crash, doesn´t matter if I confirmed
my password filled in by Password Manager, denied, or told not to remember.
Created a new profile, restarted mozilla, selected new profile, copied new link
to Location Bar, hit Enter, and immediately crashed.
At another website, when getting a warning that a certificate couldn´t get
recognized, Mozilla immediately crashed, if I allowed use for this session.
It didn´t crash, when I denied. Tested available nightlies, bug wasn´t seen in
yesterdays nightly 20040722xx xx = 09 or 08, zips downloaded as xx = 10.
Todays nightly silkently crashes in wallet.dll, as DocWatson tells.
DrWatson is triggered, Talkback not, though installed and accepted.
So this must be a regression in last day, probably

Bug 247417 Master Password Dialog still displays for those non-store password
POP accounts

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

I can't reproduce the crash with a build with the patch for bug 247417. It just
prompts, and then complains that i don't have a password.

Comment 4

[Frank Wein [:mcsmurf]]

Ok, but it's still your patch :). Backed it out locally and i don't crash anymore.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch

This part should never have been in the patch in the first place. It was part
of another hack.

Comment 6

[[e-mail]]

Comment on attachment 154184 [details] [diff] [review]
patch

yes, it's wise to not expect too much sanity from wallet ;)

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 154184 [details] [diff] [review]
patch

sr=dmose

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

checked in.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

+    PR_Free(*user);

mismatched allocator... should be nsMemory::Free

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 252979 has been marked as a duplicate of this bug. ***

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 253581 has been marked as a duplicate of this bug. ***

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for me with build 2004-07-29-09 on Windows XP.

Comment 13

[Jay Patel [:jay]]

Adding topcrash keyword for future reference.  This was a regression from 7/23
and  Talkback data also verifies that this was fixed.

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

David, this patch should go into aviary too, because the original patch was flawed.