Closed
Bug 252955
Opened 21 years ago
Closed 21 years ago
List items returning strange states
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
2.25 KB,
patch
|
pkwarren
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Steps:
Run MSAA SDK's accessible event watch
View-> Char Encodings -> Customize
Arrow through list
What happens:
Extra states reported
Expected:
A set of sane states
Assignee | ||
Updated•21 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #154256 -
Flags: review?(pkwarren)
Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 154256 [details] [diff] [review]
Correct unititialized variable situation
Still needs work. The wrong listitem is getting the focused state and focus
event.
Attachment #154256 -
Flags: review?(pkwarren)
Assignee | ||
Comment 3•21 years ago
|
||
Attachment #154256 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #154258 -
Flags: review?(pkwarren)
Updated•21 years ago
|
Attachment #154258 -
Flags: review?(pkwarren) → review+
Assignee | ||
Comment 4•21 years ago
|
||
Comment on attachment 154258 [details] [diff] [review]
Fire correct focus events, make sure focused state is set on list item event targets for them
Darin, this doesn't need to be sr='d for accessibility module correctness, just
for C++ correctness/integration super review.
Attachment #154258 -
Flags: superreview?(darin)
![]() |
||
Comment 5•21 years ago
|
||
Comment on attachment 154258 [details] [diff] [review]
Fire correct focus events, make sure focused state is set on list item event targets for them
Technically, you should really find a non-IBMer to provide SR because it is
"verboten" to have one company both write patches and approve patches for
Mozilla.
We sort-of had the same policy at Netscape... no one-group in Netscape was
permitted to both author and approve patches.
Patch looks clean to me, sr=darin.
Attachment #154258 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Comment 6•21 years ago
|
||
Checking in base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v <--
nsRootAccessible.cpp
new revision: 1.99; previous revision: 1.98
done
Checking in xul/nsXULSelectAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.cpp,v <--
nsXULSelectAccessible.cpp
new revision: 1.21; previous revision: 1.20
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•