25303 - FILE/FTP dir listings broken

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Judson Valeski]

you get two tree widgets in the window and neither fill in.

Comment 1

[Chris Waterson]

looking...

Comment 2

[Chris McAfee]

lucky waterson :-)

Comment 3

[Chris Waterson]

looks like tree/table incremental reflow or crappy XUL, because the result show 
up as soon as I resize the window. hyatt! help me!

Comment 4

[Chris Waterson]

waaah! fix my crappy XUL for me hyatt.

http://lxr.mozilla.org/mozilla/source/xpfe/components/directory/directory.xul

it's not dealing with the case where content is incrementally reflowed b/c of 
async arrival.

Comment 5

[David Hyatt]

The XUL looks good to me.

Comment 6

[Jerry Baker]

I see this happening to the sidebar as well. The tree isn't duplicated, but it 
is truncated halfway down the screen just like the FTP dirs. Related? See bug 
25334.

Comment 7

[David Hyatt]

I didn't touch the tree widget code yesterday.  karnaze or troy, were any 
changes made to incremental table reflow that I don't know about?

Comment 8

[karnaze (gone)]

I did a checkin around 6pm but that was after the bug. Prior to that, I hadn't 
checked anything in for more than a few days due to smoke test bustage.

Comment 9

[David Hyatt]

Yeah, I'm suspecting something random and weird... not tree or table-related.

Comment 10

[David Hyatt]

Resize the window, and it shows up fine.  I'm removing the blocker designation, 
since that's only valid if it's preventing you from getting work done.  It 
isn't.

Comment 11

[Judson Valeski]

changing summary from "FTP dir listings broken"

Comment 12

[leger]

Putting on PDT+ radar for beta1.

Comment 13

[leger]

Updating QA Contact.

Comment 14

[leger]

Updating QA Contact.

Comment 15

[e75644]

*** Bug 26465 has been marked as a duplicate of this bug. ***

Comment 16

[David Hyatt]

Letting waterson investigate notifications, and other stuff... make sure it's 
not the trees fault (or is the trees fault)....

Comment 17

[Chris Waterson]

*** Bug 26656 has been marked as a duplicate of this bug. ***

Comment 18

[Chris Waterson]

backatcha, baby.

Comment 19

[David Hyatt]

Is this bug fixed?

Comment 20

[David Hyatt]

Sorry, I'm giving this back.  The assertion in today's build in nsIOService is 
actually helpful to me, since it indicates to me that you're not telling me any 
contents to display, e.g., when you first bring up "c:\", the tree widget is 
there but empty.  

It's obviously the right height, since the sort column goes all the way down the 
window.  If I resize the window, thereby forcing a reflow, then you go out to 
Necko and fetch data (and then I hit the nsIOService assertion).  This indicates 
to me that you didn't actually go get any data to give to the tree.

So I don't think this is a tree widget bug.  I still think it's a notification 
bug.

Comment 21

[David Hyatt]

BTW, the ability to follow the folders as links is preposterously sexy.

Comment 22

[Chris Waterson]

The broken-ness is coming from XUL sorting. I'd put in a bunch of code to find 
the "first generated element". Unfortunately, it doesn't take into account the 
fact that the first element you create might not necessarily end up being the 
first element in the container. Zoiks!

Comment 23

[Chris Waterson]

Attachment: proposed fix

Comment 24

[Chris Waterson]

per hyatt's suggestion, remember the container and the index instead of the 
first node created. r=rjc. I'll check it in when the tree gets green.

Comment 25

[Chris Waterson]

fix checked in

Comment 26

[Tom Everingham]

verified:
NT 2000021708