253101 - Aviary branch builds do not run under Windows NT (or Windows 95)

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040724 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040724 Firefox/0.9.1+

The code checked in to correct the dependency on SHGetSpecialFolderPath
introduced by the fix for bug 246616 has been checked into the trunk but not the
Aviary branch.  Without this checkin FIrefox will not run under either Windows
NT or Windows 95.  The code required to fix this is:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/modules/libpr0n/decoders/icon/win&command=DIFF_FRAMESET&file=nsIconChannel.cpp&rev1=1.36&rev2=1.37&root=/cvsroot

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Bill Gianopoulos [:WG9s]]

Please do NOT dupe this bug to 246616 without either.
A.  Checking in t the fix or
B.  Adding "needed-aviary1.0" to the status whiteboard for bug 246616.

(sorry for bugspam,  just thought something was needed to document the need for
a fix for this or it would just get lost and not make the release).

Comment 2

[Michael Lefevre]

confirming.

Comment 3

[Asa Dotzler [:asa]]

If NT is supported, then this is a smoketest blocker.

Comment 4

[Asa Dotzler [:asa]]

fix at bug 246616?

Comment 5

[R.J. Keller]

Taking away blocking-aviary requests, since this is a smoketest blocker.

Comment 6

[Bill Gianopoulos [:WG9s]]

re comment #4.  It is not really clear to me that the final fix for the issue is
actually completely contianed in the patches attached to bug 246616.  Neil
checked in a fix with no bug number that is what fixed it so the turnk builds
now work corrrectly with windows NT.  He did post a commnet to bug 246616 saying
he fixed it but the checked in code looks different than the patches that are
attached to the bug.  I think what is required is to make this area of
nsIconChannel.cpp on the Aviary branch be the same a s the current trunk code.

Adding Neil to the cc list to see if he can lend help to fixing this.

Comment 7

[[e-mail]]

Attachment: patch

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 154520 [details] [diff] [review]
patch

r=ben from bryner's machine

Comment 9

[Brian Ryner (not reading)]

checked in.

Comment 10

[Bernard Alleysson]

(In reply to comment #3)
> If NT is supported, then this is a smoketest blocker.

Asa, could you take a look at bug 249593 and bug 248509 ? They may be smoketest
blockers too. They only happen on a subset of NT setups, the ones without IE
installed or without the latest service packs, but still are blockers for some
people (see bug 248479 for instance). Thank you.

Comment 11

[Bill Mason]

*** Bug 253456 has been marked as a duplicate of this bug. ***