253161 - bookmarks favicons should follow redirects

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The FaviconLoadListener doesn't implement nsIHttpEventSink, and so redirects for
favicons aren't being followed leading to some sites not getting a favicon loaded.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: favicons-follow-redirects-0.patch

implement the necessary interfaces to follow redirects in FavIconLoadListener.

Comment 2

[(not currently active) Ted Mielczarek]

Quick testcase: http://mavra.perilith.com/~luser/favicontest.html

Favicon is a RedirectPermanent.  Shows up in the tab, but not in a bookmark.

Comment 3

[Jo Hermans]

isn't this bug 121518 ?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> isn't this bug 121518 ?

Nope; very different bookmark icon implementations.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154403 [details] [diff] [review]
favicons-follow-redirects-0.patch

a=[e-mail]

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in on branch and trunk.

Comment 7

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change