Closed
Bug 253195
Opened 21 years ago
Closed 21 years ago
Fix a couple of subtle block reflow bugs
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
|
5.16 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
While debugging columns I found a couple of really nasty subtle block reflow
bugs. I've finally tracked them down and fixed them. Once you know where to look
the bugs are obvious. I'll attach a patch.
|
Assignee | |
Comment 1•21 years ago
|
||
So there are two bugs. PullFrameFrom doesn't detect the last line correctly
because it looks at the current block instead of the line's container. The more
deadly bug, and the one that took me a really long time to track down, is that
someone thought "lines = flow->mLines", where lines is a nsLineBox&, would
rebind the reference, but it actually just copies the linked list pointers from
one block to another. Errrk.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #154425 -
Flags: superreview?(dbaron)
Attachment #154425 -
Flags: review?(dbaron)
Attachment #154425 -
Flags: superreview?(dbaron)
Attachment #154425 -
Flags: superreview+
Attachment #154425 -
Flags: review?(dbaron)
Attachment #154425 -
Flags: review+
|
|
Assignee | |
Comment 2•21 years ago
|
||
Fix checked in. Thanks!
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•