253310 - Backport of auth manager fixes for 1.4 branch

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Includes fixes for 215487,224749,226278.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 154480 [details] [diff] [review]
Patch

Darin, could you sanity check this?

Comment 3

[Darin Fisher]

Comment on attachment 154480 [details] [diff] [review]
Patch

sr=darin

but, i would be very cautious in accepting this patch on the 1.4 branch since
it breaks binary compatibility with previous 1.4.x releases.  that's typically
a no-no especially since embedders and extension writers have no choice
sometimes but to depend on non-frozen interfaces.  it would be nice if we could
promise no interface changes on a stable branch.  the alternative in this case
would be to invent some alternate interface like "nsIHttpAuthManagerOops" and
use that only on the 1.4 branch while maintaining the existing
nsIHttpAuthManager interface :-(

that probably isn't worth the effort since we don't know of anybody that will
be broken by this... but, i'll leave it up to drivers to make the call.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 154480 [details] [diff] [review]
Patch

I'll note that the binary incompatibility is caused by the fix for bug 226278
which we need to take.	Darin's other approach would also work, but I also
don't believe it is worth the effort.  Blizzard says "gotta fix that bug
(226278)".

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 154480 [details] [diff] [review]
Patch

Talked to asa on IRC who asked around and came back with "<Asa> yeah. I say
take it."

a=blizzard/asa for 1.4.3

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.