Closed Bug 253607 Opened 20 years ago Closed 16 years ago

Warning: redeclaration of var column

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha3

People

(Reporter: timeless, Assigned: sgautherie)

References

Details

Attachments

(3 obsolete files) 

Warning: redeclaration of var column
Source File: chrome://global/content/bindings/tree.xml
Line: 766, Column: 18
Source Code:
              var column = tree.columns.getColumnFor(sib);
Attached patch Patch (obsolete) — — Splinter Review 
Assignee: varga → mcsmurf
OS: Windows XP → All
Hardware: PC → All

    
  

        Attachment #154931 -
        Flags: superreview?(neil.parkwaycc.co.uk)

        Attachment #154931 -
        Flags: review+

    
    

    
  
Comment on attachment 154931 [details] [diff] [review]
Patch

By my reckoning there are four declarations of column and they're all wrong.

        Attachment #154931 -
        Flags: superreview?(neil.parkwaycc.co.uk) → superreview-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch 2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #154931 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 155097 [details] [diff] [review]
Patch 2

That's the idea, although you've chose an odd place to put your var column;

    
    

    
  


  
someone told me, it looks better this way :)

        Attachment #155097 -
        Attachment is obsolete: true

        Attachment #155104 -
        Flags: superreview?(neil.parkwaycc.co.uk)

        Attachment #155104 -
        Flags: review?(timeless)

    
  

        Attachment #155104 -
        Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

    
  

        Attachment #155104 -
        Flags: review?(timeless) → review+

    
    

    
  
checked in 

Checking in tree.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tree.xml,v  <--  tree.xml
new revision: 1.41; previous revision: 1.40
done


    
    

    
  
-->fixed
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
What about <mozilla/toolkit/content/widgets/tree.xml> ??
It need the same fix !
Severity: normal → minor
Target Milestone: --- → mozilla1.8alpha3
Version: Other Branch → Trunk
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
It seems you just volunteered.
Assignee: mcsmurf → gautheri
Status: REOPENED → NEW

    
  

        Attachment #155104 -
        Attachment description: Last attempt ;-) → Last attempt ;-) (/Xpfe part)
[Checked in: Comment 6]

        Attachment #155104 -
        Attachment is obsolete: true

    
    

    
  
(In reply to comment #9)
> It seems you just volunteered.

Actually, it's already included in my '(Bv1a) <tree.xml> (/Toolkit part)' patch
for bug 211046 ... which I'm only missing an sr+ for checkin... ;->
Depends on: 211046

    
  
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.widgets

    
    

    
  
Fixed long ago
Status: NEW → RESOLVED
Closed: 20 years ago → 16 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: