253607 - Warning: redeclaration of var column

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[timeless]

Warning: redeclaration of var column
Source File: chrome://global/content/bindings/tree.xml
Line: 766, Column: 18
Source Code:
              var column = tree.columns.getColumnFor(sib);

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[[e-mail]]

Comment on attachment 154931 [details] [diff] [review]
Patch

By my reckoning there are four declarations of column and they're all wrong.

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

Comment 4

[[e-mail]]

Comment on attachment 155097 [details] [diff] [review]
Patch 2

That's the idea, although you've chose an odd place to put your var column;

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Last attempt ;-) (/Xpfe part) [Checked in: Comment 6]

someone told me, it looks better this way :)

Comment 6

[Mike Connor [:mconnor]]

checked in 

Checking in tree.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tree.xml,v  <--  tree.xml
new revision: 1.41; previous revision: 1.40
done

Comment 7

[Frank Wein [:mcsmurf]]

-->fixed

Comment 8

[Serge Gautherie (:sgautherie)]

What about <mozilla/toolkit/content/widgets/tree.xml> ??
It need the same fix !

Comment 9

[Frank Wein [:mcsmurf]]

It seems you just volunteered.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)
> It seems you just volunteered.

Actually, it's already included in my '(Bv1a) <tree.xml> (/Toolkit part)' patch
for bug 211046 ... which I'm only missing an sr+ for checkin... ;->

Comment 11

[Neil Deakin]

Fixed long ago