253794 - mailnews need not reimplement strtok_r

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

there's this nice nsCRT::strtok_r function:
http://lxr.mozilla.org/seamonkey/source/xpcom/ds/nsCRT.h#183

which can be used if you want a portable strtok_r implementation.

bug 248768 shows the two (!!) places where mailnews has its own impl. at the
very least, this function should only be impld _once_.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 275425 has been marked as a duplicate of this bug. ***

Comment 2

[Justin Wood (:Callek)]

add CC's that biesi initially added to a dupe'd bug

Comment 3

[Mark Banner (:standard8)]

Attachment: Remove unused functions from AB code (checked in)

The instance of the duplicated strtok function in the address book code
mentioned in bug 248768 is not actually required, the two functions that use it
are not used in the current mozilla code base. Therefore rather than trying to
fix it and not be able to test the unused code, this patch simply removes the
redundant functions.

This patch doesn't touch the imap strtok code.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 170041 [details] [diff] [review]
Remove unused functions from AB code (checked in)

Neil checked this in 2005-01-03 04:45.

Comment 5

[Mark Banner (:standard8)]

Attachment: Replace strtok type functions in Imap code.

This patch replaces the remaining Imapstrtok_r function with that from
nsCRT::strtok. I have run with this for a few days on my dev suite and have not
found any problems, I also completed the mailnews smoketests successfully.

This appears to be the last duplicated instance of strtok in mailnews.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in mailnews/imap/src/nsIMAPGenericParser.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsIMAPGenericParser.cpp,v  <-- 
nsIMAPGenericParser.cpp
new revision: 1.44; previous revision: 1.43
done
Checking in mailnews/imap/src/nsIMAPGenericParser.h;
/cvsroot/mozilla/mailnews/imap/src/nsIMAPGenericParser.h,v  <-- 
nsIMAPGenericParser.h
new revision: 1.11; previous revision: 1.10
done
Checking in mailnews/imap/src/nsImapServerResponseParser.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp,v  <-- 
nsImapServerResponseParser.cpp
new revision: 1.118; previous revision: 1.117
done
Checking in mailnews/imap/src/nsImapUrl.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapUrl.cpp,v  <--  nsImapUrl.cpp
new revision: 1.176; previous revision: 1.175
done

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

verified fixed via LXR