254047 - Bad selection from "to & cc & bcc" (dialog Select Addresses)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; cs-CZ; rv:1.8a2) Gecko/20040714
Build Identifier: Mozilla/5.0 (Windows; U; Win98; cs-CZ; rv:1.8a2) Gecko/20040714

Mozilla Mail. I choose "File -> New -> Message" in main menu. Then i choose
"Options -> Select Addresses...". This open a new dialog. I can select adresses
there. There are three buttons - "To->" (for primary recipients), "Cc->" (for
secondary recipients) and "Bcc->" (for secondary recipients not identified to
the other recipients). In oficial (english) version of Mozilla these buttons
work correct but not with czech version of Mozilla. 

Strings "To", "Cc" and "Bcc" can be localized - known as "Komu", "Kopie" and
"Skryta kopie" in Czech version. Problem is when i select contacts from local
database and click "Cc" ("Kopie" in Czech version) and then i close dialog.
There is a problem becouse contacts aren't known as "Cc" but "To".

I know where is a problem.

messenger.jar!/content/messenger/adressbook/abSelectAddressesDialog.js

There is function SelectAddressOKButton()

A part of this function is:
=================================
          switch ( text[0] )
          {
         	
            case prefixTo[0]:
              if ( toAddress )
                toAddress += ", ";
              toAddress += text.substring(prefixTo.length, text.length);
              break;
            case prefixCc[0]:
              if ( ccAddress )
                ccAddress += ", ";
              ccAddress += text.substring(prefixCc.length, text.length);
              break;
            case prefixBcc[0]:
              if ( bccAddress )
                bccAddress += ", ";
              bccAddress += text.substring(prefixBcc.length, text.length);
              break;
          }
=================================
Problem is that Mozilla compares only first character of status. In english
version this isn't problem becouse "To", "Cc", "Bcc" - there are different first
characters but in Czech version ("Komu", "Kopie", "Skryta kopie") aren't.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Adam Hauner]

Marking NEW.

http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/abSelectAddressesDialog.js#185
This bug is in code since this file first checking in CVS.

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[[e-mail]]

Comment on attachment 155033 [details] [diff] [review]
Proposed patch

Please could someone with a suitable locale test this.

Comment 4

[Michael Wolf]

(In reply to comment #3)
> (From update of attachment 155033 [details] [diff] [review])
> Please could someone with a suitable locale test this.
> 

I tested it for Sorbian. The patch works renaming the prefixes so that they
begin by the same letter (Komu, Kopija, Kopija skryta). The last one should be
skryta kopija but I wanted to test if the patch works too if all prefixes begin
by the same letter. Therefore I placed the adjective behind the substantive.

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Simon Paquet [:sipaq]]

I can't set the approval-aviary? flag here, so I'm asking for this bug to block
the aviary 1.0 releases. The bug has a patch.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 155033 [details] [diff] [review]
Proposed patch

a=asa (on behalf of the aviary team) for checkin to the aviary branch.