Closed
Bug 254175
Opened 20 years ago
Closed 20 years ago
Allow installer building to be fully localizable
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
(Keywords: fixed-aviary1.0, Whiteboard: [have patch] ready to land)
Attachments
(3 files)
4.91 KB,
patch
|
shaver
:
review+
shaver
:
approval-aviary+
|
Details | Diff | Splinter Review |
82.76 KB,
patch
|
chofmann
:
approval-aviary+
|
Details | Diff | Splinter Review |
115.92 KB,
patch
|
Details | Diff | Splinter Review |
The build process currently allows --enable-ui-locale=ab-CD so that you can build a localized version of firefox. However, this doesn't yet affect the installer. I need to fix this before the localization freeze after 1.0b I'm also going to attach a patch here to automate the building of XPI langpacks.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #155091 -
Flags: approval-aviary?
Comment on attachment 155091 [details] [diff] [review] Allow building arbitrary langpacks from a build tree OK, let's get it in the tree. I assume you've tested the differet products' installers and suchlike, of course.
Attachment #155091 -
Flags: review+
Attachment #155091 -
Flags: approval-aviary?
Attachment #155091 -
Flags: approval-aviary+
Assignee | ||
Comment 3•20 years ago
|
||
Fully localize the firefox installer files. Due to a few file-moves, this patch is readable but not really apply-able. I have tested both win32 and linux installers.
Assignee | ||
Comment 4•20 years ago
|
||
There are five file-moves involved: browser/installer/unix/installer.cfg.in -> browser/installer/unix/installer.cfg browser/installer/unix/langenus.jst -> browser/installer/unix/ab-CD.jst browser/installer/windows/langenus.jst -> browser/installer/windows/ab-CD.jst browser/installer/windows/install.it -> toolkit/locales/en-US/installer/windows/install.it toolkit/mozapps/installer/unix/wizard/installer.ini -> toolkit/locales/en-US/installer/unix/install.it
Assignee | ||
Updated•20 years ago
|
Attachment #156077 -
Flags: approval-aviary?
Comment 5•20 years ago
|
||
Adding to the radar. would to be good to get by PR but could slip a few days until Localization Freeze
Flags: blocking-aviary1.0PR+
Updated•20 years ago
|
Whiteboard: [have patch]
Comment 6•20 years ago
|
||
So, how well has this been tested? :-)
Assignee | ||
Comment 7•20 years ago
|
||
I have built and installed the firefox windows and unix installers, and tried as many options as possible. Both the installers and the resultant builds work as expected. Shaver asked me to build a tbird windows installer just to test it, and I've been trying, fighting mysterious hardware lockups on my win32 machine; the patch should not affect the tbird installer at all...
Comment 8•20 years ago
|
||
On my first attempt to test this for Thunderbird, the app went into that famous infinite process starting / process shutting down loop. I'm trying a clean clobber build now as I doubt Benjamin's patch could have caused that.
Comment 9•20 years ago
|
||
Benjamin, this patch worked fine for me with the Thunderbird windows installer. I didn't run into any problems with it.
Comment 10•20 years ago
|
||
Reading news://news.mozilla.org:119/4124bf11$0$12126$3b214f66@usenet.univie.ac.at do you want to adjust the INSTALLER_NAME var to what came out of that discussion? And if so, do you want to do that now or later?
Comment 11•20 years ago
|
||
Having the build setting the name in the convention we (the MLP) are using for uploading to ftp.mozilla.org would be really nice :)
Comment 12•20 years ago
|
||
Comment on attachment 156077 [details] [diff] [review] Fully localize the installer (readable patch) a=chofmann for PR
Attachment #156077 -
Flags: approval-aviary? → approval-aviary+
Updated•20 years ago
|
Whiteboard: [have patch] → [have patch] ready to land
Assignee | ||
Comment 13•20 years ago
|
||
I fixed this, except for the changes to the filenames produced by the installer. I need a comprehensive patch to do that, which will be a separate bug.
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•