254175 - Allow installer building to be fully localizable

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

The build process currently allows --enable-ui-locale=ab-CD so that you can
build a localized version of firefox. However, this doesn't yet affect the
installer. I need to fix this before the localization freeze after 1.0b

I'm also going to attach a patch here to automate the building of XPI langpacks.

Comment 1

[Benjamin Smedberg]

Attachment: Allow building arbitrary langpacks from a build tree

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 155091 [details] [diff] [review]
Allow building arbitrary langpacks from a build tree

OK, let's get it in the tree.  I assume you've tested the differet products'
installers and suchlike, of course.

Comment 3

[Benjamin Smedberg]

Attachment: Fully localize the installer (readable patch)

Fully localize the firefox installer files. Due to a few file-moves, this patch
is readable but not really apply-able. I have tested both win32 and linux
installers.

Comment 4

[Benjamin Smedberg]

Attachment: same patch, but uses -N so it's apply-able

There are five file-moves involved:

browser/installer/unix/installer.cfg.in -> browser/installer/unix/installer.cfg

browser/installer/unix/langenus.jst -> browser/installer/unix/ab-CD.jst
browser/installer/windows/langenus.jst -> browser/installer/windows/ab-CD.jst
browser/installer/windows/install.it ->
  toolkit/locales/en-US/installer/windows/install.it
toolkit/mozapps/installer/unix/wizard/installer.ini ->
  toolkit/locales/en-US/installer/unix/install.it

Comment 5

[chris hofmann]

Adding to the radar.  would to be good to get by PR but could slip a few days
until Localization Freeze

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

So, how well has this been tested? :-) 

Comment 7

[Benjamin Smedberg]

I have built and installed the firefox windows and unix installers, and tried as
many options as possible. Both the installers and the resultant builds work as
expected. Shaver asked me to build a tbird windows installer just to test it,
and I've been trying, fighting mysterious hardware lockups on my win32 machine;
the patch should not affect the tbird installer at all...

Comment 8

[Scott MacGregor]

On my first attempt to test this for Thunderbird, the app went into that famous
infinite process starting / process shutting down loop. I'm trying a clean
clobber build now as I doubt Benjamin's patch could have caused that.

Comment 9

[Scott MacGregor]

Benjamin, this patch worked fine for me with the Thunderbird windows installer.
I didn't run into any problems with it.

Comment 10

[Axel Hecht]

Reading news://news.mozilla.org:119/4124bf11$0$12126$[e-mail]
do you want to adjust the INSTALLER_NAME var to what came out of that discussion?
And if so, do you want to do that now or later?

Comment 11

[Robert Kaiser]

Having the build setting the name in the convention we (the MLP) are using for
uploading to ftp.mozilla.org would be really nice :)

Comment 12

[chris hofmann]

Comment on attachment 156077 [details] [diff] [review]
Fully localize the installer (readable patch)

a=chofmann for PR

Comment 13

[Benjamin Smedberg]

I fixed this, except for the changes to the filenames produced by the installer.
I need a comprehensive patch to do that, which will be a separate bug.