254316 - Remove Ctrl+r redo bindings for *nix

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Stefan [:stefanh]]

Neil told me to write a patch for this. There are 3 redo shortcuts for the *nix
users: Ctrl+Shift+Z (htmlBindings.xml), Ctrl+y and Ctrl+r
(/unix/platformHTMLBindings.xml). Not sure why Ctrl+r was assigned to redo on
*nix in the first place. But it looks like the redo binding has been Ctrl+r for
a couple of years ago (http://bugzilla.mozilla.org/show_bug.cgi?id=46015#c38).
Maybe a leftover just in the *nix case?

Comment 1

[Stefan [:stefanh]]

Attachment: Removes the Ctrl+r redo bindings for *nix

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Can we also make Shift+Ctrl+Z the default on nix?  Per
http://developer.gnome.org/projects/gup/hig/2.0/menus-standard.html#menu-standard-edit

Comment 3

[Akkana Peck]

Comment on attachment 155191 [details] [diff] [review]
Removes the Ctrl+r redo bindings for *nix

r=akkana.  I checked with several linux apps, and did a quick poll on a linux
IRC channel, and couldn't find any reason ctl-R should do Redo.

I'm surprised about gnome specifying c-s-z as the preferred redo button.  A
slim majority of the apps I checked (including some important gtk apps, like
gimp2) use c-y.  I checked with gimp folks and the choice of c-y is deliberate,
after discussion with the gnome HIG people.  I guess there's no real consensus
on which one is preferred.  If the default did change, though, it should change
here, in mail, and in firefox and t'bird, and should probably be handled as a
separate bug.  (In any case it modifies a different set of files, the xul files
rather than the xbl, which would be reason enough to separate it.)

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fair enough.

Comment 5

[Felix Miata]

I hope "redo" is not a synonym for "reload page". New converts from windoze to
Linux won't have a clue why reloading page doesn't work with Ctrl-R.

Comment 6

[Akkana Peck]

Reload Page is exactly why this bug was filed.  The offending Redo binding is
currently blocking the Reload Page binding, at least if focus is in a text control.

Comment 7

[Stefan [:stefanh]]

Neil, can you check in the patch, please?

Comment 8

[[e-mail]]

Fix checked in.