254434 - about:config should not use eval

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Erik Fabert]

+      var val = parseInt(result.value);
+      if (isNaN(val)) {

This would lead to inputs like "32xyz" be accepted as 32. Also, "067" would be 
interpreted as 55. 
Better use
val = Number(result.value);

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

> "067" would be  interpreted as 55. 

that's fine, if you enter octal numbers you can expect them  to be interpreted
as such

But per irc discussion w/ neil I'll use parseInt(val) == val, so that .5 (for
example) is not accepted

hmm, or would Number(val) == val be better?

Comment 4

[[e-mail]]

Comment on attachment 155277 [details] [diff] [review]
patch

parseInt(val) == val would wronly pass "NaN".
(result.value - 0) != (result.value | 0) is another option.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, using | 0 != - 0

Checking in xpfe/global/resources/content/config.js;
/cvsroot/mozilla/xpfe/global/resources/content/config.js,v  <--  config.js
new revision: 1.18; previous revision: 1.17
done
Checking in xpfe/global/resources/locale/en-US/config.properties;
/cvsroot/mozilla/xpfe/global/resources/locale/en-US/config.properties,v  <-- 
config.properties
new revision: 1.2; previous revision: 1.1
done