254536 - [FIX]view-source sometimes renders in quirks mode

Status: RESOLVED FIXED

(Core Graveyard :: View Source, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

To be precise, it renders in the mode of the original page.  That's poor for
perf, since classname CSS matching is much faster in standards mode (it doesn't
have to do case-insensitive crap).

I have a hack to fix that...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 155338 [details] [diff] [review]
Patch

rbs, what do you  think?

Comment 3

[rbs]

Somehow I cannot quite convince myself that all is clear here. We want a quirks
document to be parsed in quirks mode -- regarless the fact that the sandwitching
of view-source is always neat and can be considered in standards mode. (The
caveat is that the sandwitching needs the inner quirks parsing to deal with a
quirks document.) Won't your trick break this basic constraint?

Comment 4

[Boris Zbarsky [:bzbarsky]]

rbs, my patch sets the mode to standards on the parser context only during the
function call that sets the compatibility mode on the document (which will be
propagated to things like the style system and layout).

So the parser (tokenizer and DTD) both see the document in quirks or standards,
as appropriate.  The rest of gecko (content sink, document, and layout) see it
in standards.  Which is fine, because everything after the DTD is seeing the
document that the view-source DTD generates.

Comment 5

[rbs]

Comment on attachment 155338 [details] [diff] [review]
Patch

r+sr=rbs

OK, go it. I looked at the source of
HTMLContentSink::WillBuildModel() and indeed your patch achieves what you
documented above. No way to get the document in the view-source side.  Couldn't
think of anything better / less-invasive.
Might have been possible to test the parser command in
HTMLContentSink::WillBuildModel(). . But that is of dubious value. Your patch
keeps things on the view-source side.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.