255060 - Firefox and Thunderbird migration requires a Seamonkey created registry.dat file

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Tracy Walker [:tracy]]

seen with Firefox and Thunderbird branch builds.

-Delete(or rename) Mozilla folder from Application Data
-Delete(or rename) Thunderbird folder from Application Data
-Install and launch the latest builds of Firefox and/or Thunderbird

expected results:
the migration dialog should appear before any other app initial launch dialogs

tested results:
the apps pass over migration and go into initial launch dialogs.

to workaround this:
-install and launch the latest Mozilla build (registry.dat gets created)
-Delete(or rename) Firefox and Thunderbird folders from Application Data
-Install and launch the latest builds of Firefox and/or Thunderbird

With the mozilla created registry.dat, migration for both apps will now work.

Comment 1

[Tracy Walker [:tracy]]

Simply having cleaned the firefox profiles and having a mozilla created
registry.dat isn't enough. I've also noticed that Mozilla has to be set as the
default browser.  

Comment 2

[Scott MacGregor]

For me, I made outlook my default and was still able to get to the migration
screen. I wonder if the default browser/mail requirement is firefox only.

Comment 3

[Tracy Walker [:tracy]]

Ah, ine was a misinterpretation of what's happening.  Did fully testing and
found the default browser must be anything but firefox for firefox migration to
work.  Sorry for the confusion.  Asa said that Thunderbird is the same way; it
cannot be set as the default mail client in order for migratoin to work.

The situation we are creating in testing is a little unusual in that we run the
app for testing, then delete the app profile folder. But the apps should prompt
to migrate as long as there are no profiles.

Comment 4

[sairuh (rarely reading bugmail)]

filed bug 255225 for resetting default browser to IE (Windows only) upon
uninstall of Firefox.

Comment 5

[Benjamin Smedberg]

Is this Windows-only or cross-platform? I can't believe that the profile-import
code has anything to do with this, because it looks for the firefox registry.dat
file, not the seamonkey registry.dat file.

Comment 6

[Benjamin Smedberg]

With today's win32 (trunk) build, I can delete Mozilla/registry.dat, set IE as
my default browser, and the profile-migration wizard comes up. What other issues
are there?

Comment 7

[Tracy Walker [:tracy]]

The other issues are on all platforms on branch for thunderbird and firefox. And
obviously on Mac we're talking about Application Registry not registry.dat

Comment 8

[Benjamin Smedberg]

This is fallout from the decision to ask users what app to import from, instead
of importing from the default app. The assumptions in the import code were never
changed:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/migration/src/nsProfileMigrator.cpp&rev=&cvsroot=/cvsroot&mark=89-90,101-102

Comment 9

[Asa Dotzler [:asa]]

I went back and tested a build from before semi-single profile and the migration
window does come up. After semi-single profile, I get no migration window.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

I did *NOT* cause this bug. Repeat. This worked when I originally landed
migration. SSP appears to have broken this. If there were assumptions in the
original Migration code, SSP changed the environment, so the SSP changes are on
the hook for fixing this feature. You may not agree, but you don't have to. This
is how we do things around here. 

Comment 11

[Bill Gianopoulos [:WG9s]]

Well is this really a valid bug?  If the issue has nothing to do with
registry.dat as some comments seem to suggest, and is really that firfox will
not migrate profiles if it is already set as the default browser, I would think
that would be expected behavior.  I would only expect firefox to migrate
profiles on a new install if the default browser were something other than
firefox.  But maybe that's just me.

Comment 12

[Benjamin Smedberg]

Attachment: if no/bad default browser, don't shit a brick

I'm not convinced that this will fix the problem that stands, but it does help
in my linux build.

Comment 13

[Benjamin Smedberg]

Comment on attachment 155989 [details] [diff] [review]
if no/bad default browser, don't shit a brick

Absent other feedback, I just checked this in to the trunk. I now get a profile
migrator dialog no matter what the default browser is, in a new windows login.
Is this tested enough to get approval-aviary?

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: simpler patch

fall back to IE if no import source exists on Windows, return failure
otherwise. Here's how this affects each platform:

Windows: If something was set as default browser and the source does not
	 exist, assume registry bad and fall back to IE.
MacOS X: If Phoenix/Seamonkey dir does not exist, assume never had a profile
	 before and create a new one (the "buggy" behavior, which is sufficient

	 in this case since we don't have any more migrators to use now
	 that Phoenix/Seamonkey have been eliminated - at least not until
	 we get Safari, etc migrators)
Linux:	 Ditto.

Comment 15

[Scott MacGregor]

Attachment: thunderbird version of the fix

I can't follow Ben's simpler patch because:
1) I have migrators besides seamonkey on non windows platforms (such as Eudora
on OS X)
2) There is no 'safe' default like IE to fall back on.

So I went with the more complicated fix.

Comment 16

[Scott MacGregor]

the thunderbird fix has been checked into the branch and the trunk

Comment 17

[Benjamin Smedberg]

Ben checked in his simple firefox patch, so this bug is fixed for all products
and branches.

Comment 18

[Tracy Walker [:tracy]]

verified on windows branch firefox and thunderbird

Comment 19

[sairuh (rarely reading bugmail)]

I'm still seeing this on Linux (fedora core 2) using 2004082615-0.9+ when trying
to migrate from Opera.

http://testrunner.mozilla.org/test.cgi#982

should this be reopened, or a new bug filed?

Comment 20

[Scott MacGregor]

Firefox, thunderbird or both sairuh?

Comment 21

[Benjamin Smedberg]

sairuh: that is not this bug, it might need a new bug. This bug only happens
where there are *no* profiles to begin with. It has nothing to do with the
File->Import code path.

Comment 22

[sairuh (rarely reading bugmail)]

Scott: I'm currently testing from Firefox (sorry for not clarifying).

Benjamin: I'm testing Migration (starting with no mozilla or firefox profiles),
not Import. :)

again, let me know if I should spin off a separate bug. thanks!

Comment 23

[sairuh (rarely reading bugmail)]

a bit more info: as a comparison, this was not a problem when I migrated from
seamonkey to firefox (same build). I started with no ~/.mozilla, fired up
seamonkey (moz1.7.2), quit that and started firefox, which nicely presented the
migration wizard.

Comment 24

[Benjamin Smedberg]

sairuh: sorry to be unclear, I was discussing migration as well. There are two
paths for migration, which behave very differently:

1) no firefox profile, we open migration wizard with a profile created but not
yet selected (and try to find a default browser, but only on windows). This
allows full migration of netscape-style profiles which isn't possible from
File->Import

2) from the firefox File->Import menu, we already have a profile selected.
Especially for netscape-style profiles, the migration options are much more limited.

These two methods can behave very differently, and QA should be done separately.

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 155989 [details] [diff] [review]
if no/bad default browser, don't shit a brick

please don't request approval until you have a fully reviewed patch. thanks.

Comment 26

[sairuh (rarely reading bugmail)]

I filed bug 257215 for the Opera migration issue I experienced in comment 19,
22, 23.