255132 - bookmarks.bak doesn't get updated past first write

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

From bug 218636, comment #26:
> On my system the bookmarks.bak file doesn't seem to get updated when
> bookmarks.html is changed and Firefox restarted, it simply stays the same as it
> was when first created (according to nsIFile.idl copyTo can fail if the target
> file already exists).
> 
> Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040809 Firefox/0.9.1+

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: bookmarks-backup-fix-0.patch

Removes the backup file first before doing CopyTo.  Apparently, CopyTo only
fails if the target file exists on windows.  (At least, it doesn't seem to do
so on linux.)  Damn windows.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 155769 [details] [diff] [review]
bookmarks-backup-fix-0.patch

a=me

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in

Comment 4

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change