255151 - Open Import wizard instead of file picker when choosing Import in bookmarks

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Blake Ross]

Right now, we open this really scary and advanced file picker when you choose
Import in the Bookmarks window and force users to understand how bookmarks are
stored behind the scenes. Instead, we should present the Import wizard you get
when choosing File -> Import in the Firefox window, only pared down to import
just bookmarks (in other words, don't even show the second screen where you
choose what to import). Significant bonus points if you add a radio button to
the first screen (where you choose the application to import from) that just
says "From file" and has an associated textbox/browse button, so we can continue
to offer the more flexible functionality we currently have for advanced users.

Comment 1

[Ryan Polk (Quark)]

I'm trying to get this working, though no promises.  However, it strikes me that
the "From File" will have to be a localizable string so the string itself should
go in before l10n freeze.

Comment 2

[Ryan Polk (Quark)]

Attachment: l10n string only

Will this do, or does migration.properties need another sourceName line?

Comment 3

[Ryan Polk (Quark)]

Requesting Blocking 1.0PR to get the string in before l10n freeze, if not in
time for PR itself.

Comment 4

[Ryan Polk (Quark)]

Attachment: l10n strings, one extra string

Comment 5

[Ryan Polk (Quark)]

Attachment: v1, bookmarks and migration changes

This has everything working for me in Bookmarks Manager's Import, with From
File calling the old filepicker.

I still need to heavily test regular migration (especially automigrate) to make
sure nothing there broke.

Comment 6

[Ryan Polk (Quark)]

Comment on attachment 157814 [details] [diff] [review]
v1, bookmarks and migration changes

I've Win32 tested this with every combination of Automigrate and manual I can
(IE/Moz/Nothing) and it all worked.  Bookmarks was tested before and worked.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 157765 [details] [diff] [review]
l10n strings, one extra string

r=[e-mail]

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 157814 [details] [diff] [review]
v1, bookmarks and migration changes

r=[e-mail]

Looks good to me, though ben knows the migration code better.  Will this append
bookmarks the current set, or does it replace the user's current bookmarks?

Comment 9

[Ryan Polk (Quark)]

This appends the bookmarks, it follows the same exact behavior as doing File ->
Import and just selecting Bookmarks (excluding the From File alternative).

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 157814 [details] [diff] [review]
v1, bookmarks and migration changes

"OK"

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in on aviary, trunk soon

Comment 12

[Tracy Walker [:tracy]]

confirmed fixed on Windows Firefox Branch 2004-09-10-08-0.9 and Mac Firefox
Branch 2004-09-10-07-0.9

Comment 13

[Asaf Romano (gone)]

blocker regression on mac: bug 259039

Comment 14

[Mike Connor [:mconnor]]

there's no immediate need to back this out just because of bustage on Mac.  Its
a blocker on Mac, but backing this out everywhere isn't necessary.

Comment 15

[Ryan Polk (Quark)]

Ben and Vlad have checked this (and the patch for bug 259039) into trunk.

Comment 16

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change