255465 - Ctrl+= should enlarge text in Help viewer

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Jeff Walden (gone starting June 8)]

The problem's simple: in the Help viewer, pressing Ctrl+(plus key on qwerty
section of keyboard) doesn't work, while pressing Ctrl+(plus key on NumPad)
works.  Why?  The plus key on the qwerty section isn't really the plus key --
it's the equals (=) key.  Test it -- Ctrl+Shift+= will enlarge the text.

Firefox and Seamonkey have known about this problem for a while, so they've
added a second <key/> element that takes care of the = problem.  Patch coming up
to do the same for Help...note also that it's a l10n change because I have to
add = as an entity, so it needs to get in before PR1.0.

Comment 1

[Jeff Walden (gone starting June 8)]

Attachment: Patch

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 156003 [details] [diff] [review]
Patch

Requesting review from rlk...

Comment 3

[R.J. Keller]

Comment on attachment 156003 [details] [diff] [review]
Patch

r=[e-mail], thanks Jeff! I would like an ID attribute but I guess it
isn't necessary.

Comment 4

[Jeff Walden (gone starting June 8)]

(In reply to comment #3)
> (From update of attachment 156003 [details] [diff] [review])
> r=[e-mail], thanks Jeff! I would like an ID attribute but I guess it
> isn't necessary.

I was following the style that the main browser uses, which is not to assign an id:

http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser-sets.inc#285

I also figured the id would only be useful if it were hooked up to something, as
the id is hooked up to the relevant menu item in the main browser.

Comment 5

[R.J. Keller]

Not a doc change, so removing bug dependency.

Comment 6

[Jeff Walden (gone starting June 8)]

We're adding an entity for l10n...requesting blocking-aviary1.0PR.

Comment 7

[chris hofmann]

Comment on attachment 156003 [details] [diff] [review]
Patch

approved. but needs to get in quickly

Comment 8

[Jeff Walden (gone starting June 8)]

> (From update of attachment 156003 [details] [diff] [review])
> approved. but needs to get in quickly

Steffen, any chance you can check this in?

Comment 9

[R.J. Keller]

Steffen got it. This is in on the trunk, so fixed.

Comment 10

[Steffen Wilberg]

Checked in br & trunk. I also added an id key_textZoomEnlarge2 just in case an
extension wants to change it.